Aleix Pol Gonzalez authored Feb 08, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

We are only checking the previous size to see if it needs to emit a
change, we were fetching twice in practice.

CCBUG: 432657


(cherry picked from commit 76780c71)

Aleix Pol Gonzalez authored Feb 08, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

When the details are required, they'll be requested. This way we don't
fetch the updatable packages updates when the user just wants to find an
app.

CCBUG: 432657


(cherry picked from commit b9f709b9)

Aleix Pol Gonzalez authored Feb 05, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

This way we make sure it doesn't block the main thread


(cherry picked from commit ab6ce441)

Aleix Pol Gonzalez authored Feb 09, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

Prevent a QString from being created and destroyed every time we call
PackageKitResource::state


(cherry picked from commit dd18487e)

Aleix Pol Gonzalez authored Feb 08, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

This is something Fedora seems to do and we were not honoring.


(cherry picked from commit 9572f935)

Aleix Pol Gonzalez authored Feb 08, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

It was only used for debugging an edge case.


(cherry picked from commit 18bbc381)

Aleix Pol Gonzalez authored Feb 09, 2021 and Aleix Pol Gonzalez committed Feb 09, 2021

CCBUG: 432683


(cherry picked from commit 72aee3c9)

Aleix Pol Gonzalez authored Feb 05, 2021 and Aleix Pol Gonzalez committed Feb 05, 2021

(cherry picked from commit 42b084fb)

Aleix Pol Gonzalez authored Feb 04, 2021 and Aleix Pol Gonzalez committed Feb 05, 2021

(cherry picked from commit b0c52067)

Aleix Pol Gonzalez authored Feb 04, 2021 and Aleix Pol Gonzalez committed Feb 05, 2021

Otherwise it looks all weird for no reason.


(cherry picked from commit 9b4321d1)

Aleix Pol Gonzalez authored Feb 04, 2021 and Aleix Pol Gonzalez committed Feb 04, 2021

It read very weird to see "3 packages upgraded" when there actually are
two.


(cherry picked from commit 4013a282)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

(cherry picked from commit a5f2567b)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Aleix Pol Gonzalez authored Jan 28, 2021 and Nate Graham committed Jan 28, 2021

We were giving all of them and the proxy isn't smart enough to do the
filtering.

BUG: 428681


(cherry picked from commit c1224ba8)

Aleix Pol Gonzalez authored Jan 23, 2021 and Aleix Pol Gonzalez committed Jan 23, 2021

Now that we are showing them sorted, it's clear that sometimes they're
repeated on distros that there's less of a 1:1 mapping on resources
(e.g. KDE Neon).

Make sure then that we only print them once.


(cherry picked from commit 3feada8b)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Aleix Pol Gonzalez authored Jan 22, 2021 and Aleix Pol Gonzalez committed Jan 22, 2021

Makes it easier to see if a specific package is being upgraded.


(cherry picked from commit fc496ad4)

GIT_SILENT

As discovered by Piotr, attempting to update some KNewStuff originated
packages in Discover results in the update not in fact being updated,
without anything happening in Discover apart from the update just
staying around in the UI. This patch forwards an error from
KNSCore::Engine which gives some further information as to what the user
can do to perform this update.

This is a half-solution to the problem, as the TODO added in here
suggests, but it seems to me better to be explicit about the problem to
our users, rather than just not doing anything, and informing them how
they can fix it themselves. Until we have a full query system for
Discover's transactions, this seems likely to be the best we can do (and
actually implementing that system will take some time to get right, and
we don't want to just ignore the problem until them).

BUG:430812

Aleix Pol Gonzalez authored Jan 14, 2021 and Aleix Pol Gonzalez committed Jan 18, 2021

Should make the instances much lighter, which is important as there's
tons of them.

BUG: 431364

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

If the user was gambling his luck by trying to uninstall the "System
Upgrade" entry we create for offline upgrade, now they'll get an error
message rather than a crash.

Instead of creating a new one when preparing a new update. It would get
confused and crash sometimes. Not pretty.

Backends will need to make sure that no wrong resources are offered.
This is necessary because when we query by appstream id we might have to
return some resources where we match on their alternative names rather
than the actual.

BUG: 427243

Only do it when we need it instead of fetching them all at start.

There should at least be a package to upgrade to consider it.

The message will already appear as a system notification and the updates
page will request to reboot (and offer a button). We do not need yet
another dialog pressuring us.

It makes libflatpak (libsoup internally) go bonkers. It also makes the
whole startup much slower (understandably).
By using FlatpakRemoteRef instead of querying the FlatpakInstallation we
have the opportunity for some optimisations since we're querying the
FlatpakRemoteRef twice for some (most?) available packages.

It doesn't make sense to pass the installation together with the
resoruce because the resource already knows its installation (and it's
constant at that).

It's not very useful to create the cancellable when we won't be able to
use it. Pass the one from the backend so we can cancel jobs upon closing
at least.