1. 23 Sep, 2020 2 commits
  2. 21 Sep, 2020 1 commit
  3. 18 Sep, 2020 2 commits
  4. 17 Sep, 2020 7 commits
  5. 16 Sep, 2020 2 commits
  6. 14 Sep, 2020 3 commits
    • Nate Graham's avatar
      Add icons to review buttons · 95b7660f
      Nate Graham authored
      95b7660f
    • Nate Graham's avatar
      Use real buttons for reading and writing reviews · f1410247
      Nate Graham authored
      Right now the way you access the sheets to read and write reviews is to
      click on link buttons in odd places, which suffer from various minor
      issues:
      - Typically underlined link text opens a URL, not another page in the UI
      - Link buttons are very small and can be missed when they're in a rich
        page layout
      - The "show all reviews" link is at the top of the reviews section, not
        at the bottom where you would expect it (the flow is look at the
        three top reviews -> want to see more, which means that it should be
        below the three top reviews, not above)
      
      This commit addresses those issues by making the buttons into real
      Buttons and placing them both in a row below the three top reviews.
      f1410247
    • Arjen Hiemstra's avatar
      Parent dynamically created actions to actionstoolbar in Settings page · c9438fc3
      Arjen Hiemstra authored
      While frameworks/kirigami!95
      fixes the issue that things using ActionToolBar crash when actions
      disappear, it does not fix the underlying issue with actions
      disappearing. This does.
      
      When using createObject(null), a reference to the created object needs
      to be kept, otherwise the object gets destroyed. Unfortunately, passing
      the object to C++ means the JavaScript engine thinks there are no more
      references to the object and it garbage collects the objects. This then
      causes a crash since the toolbar wants to access the action. See also
      https://bugreports.qt.io/browse/QTBUG-25978
      
      To avoid this, parent the created actions to the ActionToolBar so they
      are only deleted when the toolbar is also deleted. Since the actions do
      not change, there is no risk that we end up with a lot of dangling
      actions here.
      c9438fc3
  7. 11 Sep, 2020 3 commits
  8. 09 Sep, 2020 3 commits
    • David Edmundson's avatar
      Disable UserFeedback surveyInterval · 477024ac
      David Edmundson authored and Volker Krause's avatar Volker Krause committed
      surveyInterval is something meant to be set by a user through a UI
      rather than an application directly.
      
      Given discover doesn't have surveys it makes sense to disable it.
      477024ac
    • Nate Graham's avatar
      Make all OverlaySheets window-modal · 27a77073
      Nate Graham authored
      Right now half of Discover's OverlaySheets are view-modal and the other
      half are window-modal. This feels arbitrary to the user, and view-modal
      sheets look weird since the global drawer doesn't darken. This is
      because it's still interactive, but there's really no point in being
      able to interact with the global drawer while a sheet is open anyway. So
      let's just make them all window-modal.
      
      BUG: 426065
      FIXED-IN: 5.20
      27a77073
    • Aleix Pol Gonzalez's avatar
      Update Author list · 02c1d389
      Aleix Pol Gonzalez authored
      Adds Nate and Dan Leinir, who have been contributing regularly.
      Removes Jonathan Thomas who hasn't done much in Discover and hasn't
      contributed in a long while.
      02c1d389
  9. 08 Sep, 2020 4 commits
  10. 07 Sep, 2020 1 commit
  11. 05 Sep, 2020 2 commits
  12. 01 Sep, 2020 6 commits
  13. 27 Aug, 2020 2 commits
    • Nate Graham's avatar
      Make addons sheet list item text look like Kirigami.BasicListItem text · 01d769f3
      Nate Graham authored
      Thei is a final tweak to the UI and makes the list items look like
      BasicListItems by using a level 5 Heading as the title and small text
      for the subtitle.
      01d769f3
    • Nate Graham's avatar
      Improve and modernize UI of Addons sheet · 4087d2b4
      Nate Graham authored
      Various improvements:
      - Put the bottom buttons in a footer so they can't scroll out of view
      - Rename "Discard" button to "Reset" since "Discard" implies closing the
        sheet
      - Move Apply and Reset buttons over to the right side, as is typical
      - Disable rather than hide the Apply and Reset buttons
      - Remove the icons since they add no information and were all the same
      - Make subtext less opaque rather than italic, as is our style (we can't
        simply port to `Kirigami.BasicListItem` yet because it can't support
        showing a checkbox to the left of the icon)
      
      BUG: 425827
      FIXED-IN: 5.20
      4087d2b4
  14. 26 Aug, 2020 2 commits
    • Vlad Zahorodnii's avatar
      Fix a crash in flatpak update notifier · 5daaa842
      Vlad Zahorodnii authored and Aleix Pol Gonzalez's avatar Aleix Pol Gonzalez committed
      Currently, the update notifier will crash due to a segmentation fault if
      a flatpak package has been updated.
      
      The segmentation fault occurs because the installationChanged() callback
      expects the user data to have a type of FlatpakNotifier, but in reality
      it's FlatpakNotifier::Installation.
      
      In order to fix the crash, this patch makes the installationChanged()
      callback cast user data to correct type.
      5daaa842
    • Nate Graham's avatar
      Improve UI of proceed sheet · c0372aec
      Nate Graham authored
      Right now if the text is really long, it gets elided at the bottom so
      you need to click a button to see the rest, and the two distinct
      sections of the text are kind of unclear.
      
      This commit puts the text in the sheet's own scrollview so you can scroll
      immediately, and adds a line break between the sections. It also puts the
      bottom buttons in a footer, which looks better.
      
      BUG: 419341
      FIXED-IN: 5.20
      c0372aec