Reduce indentation where possible
Proper variable scope

Don't let instances fall through when we fail

Prefer using smart pointers or parenting to manual deleting

Backends should be smart enough to take the query regardless of their
state.

BUG: 398746

GIT_SILENT

QT_MIN_VERSIONS is Qt 5.11 for Plasma 5.14. Agreed at kickoff meeting.  Set everywhere for clearity and consistency.

CCMAIL: montel@kde.org

Summary:
Fixes minor memory leak in the KNSBackend, the destructor of KNSBackend
failed to delete the contents of the m_rootCategories vector.

Test Plan:
Build with -fsanitize=address
Open and close Discover

Reviewers: apol

Reviewed By: apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D15145

Makes for a more reliable update experience.

BUG: 397938

BUG: 397759

Summary:
Implemented Version checker for fwupd in FindLIBFWUPD.cmake

    * Implemented Version Checker in FindLIBFWUPD.cmake
    * Reduced the Minimum Required version of Fwupd to 1.06 [Not Tested, bug reports says it builds successfully on 1.06]

Related Bugs:

    * https://bugs.kde.org/show_bug.cgi?id=397377
    * https://bugs.kde.org/show_bug.cgi?id=397378

Reviewers: apol, davidedmundson

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma, #discover_software_store

Differential Revision: https://phabricator.kde.org/D14933

BUG: 397192

It seems like expecting developers to offer a proper changelog is a lot
to ask. At least show something so the user isn't on his own to see
what's happening.

BUG: 397201

Summary:
This Patch brings the following fixes:

   *  Now It shows proper release data.
   *  Now showing proper size.
   *  added a default icon for updates (device-notifier)
   *  fixes some end-case

Reviewers: apol, davidedmundson

Reviewed By: apol

Subscribers: ngraham, plasma-devel

Tags: #plasma, #discover_software_store

Differential Revision: https://phabricator.kde.org/D14649

* Brings uniform variable name and spaces between function.
* Changed License in findLIBFWUPD.cmake as per discussion here (https://phabricator.kde.org/T9305)

Don't try to open a search applistpage after switching to updates
(actually after switching to a page without a search field).

Thanks Dr. Chapatin for the test case!

BUG: 391931

Summary: There was no check condition, that the variables in FINDLIBFWUPD.cmake file is set or unset. This diff checks for it. Also, there was a discrepancy for fwupd lib to required or optional, this fixes it. After applying this patch, the build errors are fixed.

Reviewers: apol, davidedmundson

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma, #discover_software_store

Differential Revision: https://phabricator.kde.org/D14566