1. 26 Sep, 2019 1 commit
  2. 25 Jul, 2019 1 commit
    • Dan Leinir Turthra Jensen's avatar
      Add icons to Categories, Installed, and Sources globaldrawer entries · 29fb6ce9
      Dan Leinir Turthra Jensen authored
      Summary:
      At some point, icons were removed from a number of entries in the global
      drawer, but with the many other changes which have happened since then
      this now leaves the sidebar looking somewhere between overly vacant and
      broken (with some overweight toward the latter). This patch adds these
      icons back in, as well as a couple of others, which results in a global
      drawer which looks considerably more completely loaded.
      
      This is furthermore based on feedback from the Plasma Mobile Todo[1] notes
      entry, which at time of writing contains the following (amongst others):
      
      Discover:
      Global toolbar:
      - Installed and Sources should have icons
      - Categories should either have icons or be less indented
      
      [1] https://notes.kde.org/p/plasma-mobile-todo
      
      Parent Categories created by the category reader
      
      Test Plan:
      See before without icons looks empty and just a tiny bit broken, and after
      with icons included looks fully populated (screenshots incoming)
      
      Before, no icons on the front page:
      {F7090565}
      
      Before, no icons in the applications subcategory:
      {F7090567}
      
      After, icons on the front page:
      {F7090570}
      
      After, icons in the applications subcategory:
      {F7090572}
      
      Reviewers: #discover_software_store, #vdg, ngraham, apol
      
      Reviewed By: #discover_software_store, #vdg, ngraham, apol
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22716
      29fb6ce9
  3. 28 May, 2019 1 commit
    • Björn Feber's avatar
      Use onClicked for Home button · 66f3bec0
      Björn Feber authored
      Summary:
      BUG: 407636
      FIXED-IN: 5.16.0
      
      Buttons should use onClicked instead of onPressed.
      
      Test Plan: Click on the Home button. It now behaves correctly.
      
      Reviewers: #plasma, #vdg, ngraham, apol
      
      Reviewed By: #vdg, ngraham, apol
      
      Subscribers: ngraham, #vdg, plasma-devel, #plasma
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21436
      66f3bec0
  4. 17 May, 2019 1 commit
  5. 15 May, 2019 3 commits
    • Nate Graham's avatar
      Use a more conventional sidebar header apparance in desktop view · 75e24b05
      Nate Graham authored
      Summary:
      Discover uses the `Kirigami.GlobalDrawer` for its navigation sidebar. This component is
      designed to be used for showing global actions and hiding when not in use, and displays
      a big banner image on top. This banner concept is borrowed from Android, which has the
      same kind of global drawers full of actions with banners on top. So the concept is
      somewhat familiar on mobile. However on the desktop, this "sidebar with banner image on
      top" UI is not common and feels out of place, giving Discover an odd default appearance
      since the sidebar is permanently visible but doesn't look like other apps' sidebars.
      
      This patch adjusts the sidebar appearance to look and feel more conventional in the
      desktop view, keeping the banner version only for the mobile view.
      
      Test Plan:
      Desktop view: {F6826154}
      Mobile view: {F6826086}
      (The extra space under the banner image is a pre-existing bug not introduced with this patch)
      
      Now Discover's sidebar looks quite similar to System Settings' sidebar, which is very
      visually appealing: {F6826158}
      
      Reviewers: #vdg, #discover_software_store, apol, ndavis
      
      Reviewed By: #vdg, #discover_software_store, apol, ndavis
      
      Subscribers: filipf, ndavis, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21234
      75e24b05
    • Nate Graham's avatar
      Fix color deprecation warning · f2369a2d
      Nate Graham authored
      f2369a2d
    • Nate Graham's avatar
      Use view background color for sidebar to match other sidebars · 1658a360
      Nate Graham authored
      Summary:
      Generally, left sidebars in Kirigami-style apps (e.g. System Settings) use the view
      background color. Let's do the same in Discover when it's displaying the Desktop view.
      
      Need to bump the Kirigami version to have access to `Theme.colorSet`
      
      Test Plan:
      Sidebar is now a pleasing off-white, same as System Settings
      {F6824729}
      
      Reviewers: #vdg, #discover_software_store, apol
      
      Reviewed By: #discover_software_store, apol
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21229
      1658a360
  6. 09 Mar, 2019 1 commit
  7. 15 Dec, 2018 1 commit
  8. 26 Nov, 2018 1 commit
  9. 14 Nov, 2018 1 commit
  10. 08 Nov, 2018 2 commits
  11. 03 Aug, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      Fix navigation after search · e41df0e3
      Aleix Pol Gonzalez authored
      Don't try to open a search applistpage after switching to updates
      (actually after switching to a page without a search field).
      
      Thanks Dr. Chapatin for the test case!
      
      BUG: 391931
      e41df0e3
  12. 12 Jul, 2018 1 commit
  13. 23 May, 2018 1 commit
  14. 01 Mar, 2018 1 commit
  15. 22 Feb, 2018 2 commits
    • Nate Graham's avatar
      Reduce sidebar width · bfa25177
      Nate Graham authored
      Summary:
      BUG: 385992
      FIXED-IN: 5.12.3
      
      This is a hack to work around the fact that we're using the wrong UI element for Discover's sidebar (see [[https://bugs.kde.org/show_bug.cgi?id=390928|Bug 390928]]). We use a Kirigami GlobalDrawer for the sidebar, which is problematic because the GlobalDrawer's width is always a minimum of 360 pixels on the desktop--far too wide for our use case (see [[https://bugs.kde.org/show_bug.cgi?id=390927|Bug 390927]]).
      
      Replacing the GlobalDrawer with something more appropriate is going to be a lot of work, so until then, let's not torture our users with the humongous sidebar any longer and just force it to be a smaller size for now.
      
      I think this is a vast visual improvement because it returns the focus to the content, rather than the navigation. It makes Discover feel less "fat."
      
      Test Plan:
      Before, small window:
      {F5726133}
      
      After, small window:
      {F5726132}
      
      Before, medium window:
      {F5726113}
      
      After, medium window:
      {F5726114}
      
      Before, app page:
      {F5726115}
      
      After, app page:
      {F5726116}
      
      Before, default view:
      {F5726137}
      
      After, default view:
      {F5726138}
      
      We may want to consider changing the default window size to be less wide if this patch lands, since with a narrower sidebar, the main view doesn't need to be so wide.
      
      Reviewers: #discover_software_store, apol
      
      Reviewed By: #discover_software_store, apol
      
      Subscribers: acrouthamel, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D10756
      bfa25177
    • Aleix Pol Gonzalez's avatar
      Improve search field behavior · fb0e2f7d
      Aleix Pol Gonzalez authored
      Make sure we don't show an application page when the search changes.
      Go back to the page where we came from when the search field is empty.
      
      BUG: 390909
      fb0e2f7d
  16. 21 Feb, 2018 1 commit
  17. 18 Jan, 2018 1 commit
  18. 08 Jan, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      Simplify search UX on non-application lists · 08d19bc8
      Aleix Pol Gonzalez authored
      Now that pressing enter is required, it makes less sense to jump to the
      home page when the search is cleared.
      Don't show the search field on updates, it's weird and not really useful.
      Make sources filtering case insensitive.
      
      BUG: 384463
      08d19bc8
  19. 04 Jan, 2018 1 commit
  20. 27 Oct, 2017 1 commit
  21. 16 Oct, 2017 1 commit
  22. 06 Oct, 2017 1 commit
  23. 05 Oct, 2017 2 commits
  24. 20 Sep, 2017 1 commit
  25. 15 Sep, 2017 1 commit
  26. 10 Aug, 2017 1 commit
  27. 10 Jul, 2017 3 commits
  28. 13 Apr, 2017 1 commit
  29. 14 Mar, 2017 1 commit
  30. 22 Dec, 2016 3 commits
  31. 21 Dec, 2016 1 commit