Discover merge requestshttps://invent.kde.org/plasma/discover/-/merge_requests2023-02-23T13:59:49Zhttps://invent.kde.org/plasma/discover/-/merge_requests/259Draft: Check the current application source2023-02-23T13:59:49ZViorel-CΔtΔlin RΔpiΘeanuDraft: Check the current application sourceMake sure that the source entry is checked if the application source
and version match the current model.
BUG:450114Make sure that the source entry is checked if the application source
and version match the current model.
BUG:4501145.24https://invent.kde.org/plasma/discover/-/merge_requests/81Revamp homepage2022-10-29T13:34:09ZCarl Schwancarl@carlschwan.euRevamp homepage![image](/uploads/bbae119080801497682adcd2cfcb4d38/image.png)
![image](/uploads/965a483558623c74f8e94b33e0db51ed/image.png)
@teams/vdg![image](/uploads/bbae119080801497682adcd2cfcb4d38/image.png)
![image](/uploads/965a483558623c74f8e94b33e0db51ed/image.png)
@teams/vdg5.24https://invent.kde.org/plasma/discover/-/merge_requests/352Request inhibiting sleep while transactions are on2022-08-24T09:21:11ZAleix Pol GonzalezRequest inhibiting sleep while transactions are onBUG: 401304BUG: 4013045.24https://invent.kde.org/plasma/discover/-/merge_requests/341Do not change the sorting among resources in the default backend2022-07-29T14:22:53ZAleix Pol GonzalezDo not change the sorting among resources in the default backendIt would make us swap them unnecessarily, breaking the already curated
sorting.
BUG: 451667It would make us swap them unnecessarily, breaking the already curated
sorting.
BUG: 4516675.24Aleix Pol GonzalezAleix Pol Gonzalezhttps://invent.kde.org/plasma/discover/-/merge_requests/331pk: Allow some error codes from offline updates2022-07-21T01:50:05ZAleix Pol Gonzalezpk: Allow some error codes from offline updatesBUG: 443090BUG: 4430905.24Aleix Pol GonzalezAleix Pol Gonzalezhttps://invent.kde.org/plasma/discover/-/merge_requests/330odrs: Make sure we don't fail when the application page is opened early2022-07-20T22:53:39ZAleix Pol Gonzalezodrs: Make sure we don't fail when the application page is opened earlyIf it's too early, on the packagekit backend the version won't be
populated yet. In this case we just skip fetching and refetch when the
versions change.
BUG: 426270If it's too early, on the packagekit backend the version won't be
populated yet. In this case we just skip fetching and refetch when the
versions change.
BUG: 4262705.24Aleix Pol GonzalezAleix Pol Gonzalezhttps://invent.kde.org/plasma/discover/-/merge_requests/285flatpak: Centralise remote integration in FlatpakBackend2022-05-17T11:43:38ZAleix Pol Gonzalezflatpak: Centralise remote integration in FlatpakBackend* Ensure remotes are integrated as sources when an installation
transaction adds them
* Make sure we have a source available as soon as we know a remote is
present, so it can be used.
BUG: 443745
---
I'd suggest merging back into 5.24...* Ensure remotes are integrated as sources when an installation
transaction adds them
* Make sure we have a source available as soon as we know a remote is
present, so it can be used.
BUG: 443745
---
I'd suggest merging back into 5.24 as it fixes a rather important crash. For me it's not as reproducible as for reporters so testing would be very welcome.
In exchange it also fixes the flatpaktest that had been broken for a while.5.24https://invent.kde.org/plasma/discover/-/merge_requests/284libdiscover: Fix Discover doesn't show license or description of local package2022-05-17T11:43:34ZFushan Wenlibdiscover: Fix Discover doesn't show license or description of local packageWhen setting details of a package, also emit `licensesChanged` and `longDescriptionChanged`,
so when opening a local package using PackageKit backend, the
application page can show licenses and description when the details are
fetched.
...When setting details of a package, also emit `licensesChanged` and `longDescriptionChanged`,
so when opening a local package using PackageKit backend, the
application page can show licenses and description when the details are
fetched.
BUG: 4521505.24Fushan WenFushan Wenhttps://invent.kde.org/plasma/discover/-/merge_requests/280pk: Prefer upgrades that share architecture2022-05-17T11:36:44ZAleix Pol Gonzalezpk: Prefer upgrades that share architectureOn some distros, PackageKit will offer other architectures' updates to
the packages. Make sure we don't go with these.
BUG: 444600On some distros, PackageKit will offer other architectures' updates to
the packages. Make sure we don't go with these.
BUG: 4446005.24https://invent.kde.org/plasma/discover/-/merge_requests/298Mobile mode search page minor bug fixes2022-05-11T20:42:24ZMatej Starcmatej.starc@protonmail.comMobile mode search page minor bug fixesThis MR contains some minor bug fixes for mobile search page.
- [x] Page title items not correctly aligned vertically (because of Controls.Control bottom & top padding).
- [x] SearchPage (mobile) not hiding SearchFiled after it goes bac...This MR contains some minor bug fixes for mobile search page.
- [x] Page title items not correctly aligned vertically (because of Controls.Control bottom & top padding).
- [x] SearchPage (mobile) not hiding SearchFiled after it goes back to widescreen mode. "Fix" for a reported [BUG](https://bugs.kde.org/show_bug.cgi?id=449770).
Stuff that would (probably) need onHidden signal implemented:
- [ ] Transfer search text from both search fields one to another (since search result persist, why wouldn't the text too ?).
- [ ] (**Need opinion on this**) SearchField hide/show with signals. Instead of binding search field visibility to !window.wideScreen - (as I am currently [doing](https://invent.kde.org/plasma/discover/-/merge_requests/298/diffs?commit_id=b52c4ef9c70834738b88973fa0f29fe2c238c6fc)), should I just make it change visibility depending on onShown/onHidden signals ?
What is onHidden signal mentioned above ?
- A signal that is emitted when mobile ui is hidden (when it goes back to widescreen mode it would emit this signal).5.24https://invent.kde.org/plasma/discover/-/merge_requests/296updates: Do not reboot if one of the update transactions failed2022-05-09T11:41:59ZAleix Pol Gonzalezupdates: Do not reboot if one of the update transactions failedIt gives the user the chance to see what went down.
BUG: 452165It gives the user the chance to see what went down.
BUG: 4521655.24https://invent.kde.org/plasma/discover/-/merge_requests/275Fix searchfield focus on touch launch2022-03-18T14:28:11ZNate GrahamFix searchfield focus on touch launchWe don't want to focus the search field by default when Discover is
launched with a touch, because then the virtual keyboard appears in the
user's face and covers up the content.
There is existing code to do this, but it's not quite wor...We don't want to focus the search field by default when Discover is
launched with a touch, because then the virtual keyboard appears in the
user's face and covers up the content.
There is existing code to do this, but it's not quite working. We want
the magic condition to be toggling the `focus:` property, which is what
controls whether it has focus by default. We don't need to care about
this if the user takes an action to explicitly focus it; that's all
right.
cc @apol @ahiemstra5.24https://invent.kde.org/plasma/discover/-/merge_requests/262Set textFormat in Label to StyledText2022-02-23T16:02:11ZTobias FellaSet textFormat in Label to StyledTextApparently AutoText isn't smart enough to detect this
Before
![Screenshot_20220222_155147](/uploads/71f22b80001e69e8e40f15ad1f536957/Screenshot_20220222_155147.png)
After
![Screenshot_20220222_160014](/uploads/aa0706f1c2adc20ac47be3b53...Apparently AutoText isn't smart enough to detect this
Before
![Screenshot_20220222_155147](/uploads/71f22b80001e69e8e40f15ad1f536957/Screenshot_20220222_155147.png)
After
![Screenshot_20220222_160014](/uploads/aa0706f1c2adc20ac47be3b5348f0ab0/Screenshot_20220222_160014.png)5.24https://invent.kde.org/plasma/discover/-/merge_requests/245fix integer overflow in backends2022-02-12T14:29:34ZJonas Knarbakkfix integer overflow in backendsThe size of the flatpak package org.freedesktop.Sdk.Debug exceeds the value of INT_MAX causing a integer overflow.
the API for both flatpak and package-kit return a unsigned 64 bit integer so that's what should be used.The size of the flatpak package org.freedesktop.Sdk.Debug exceeds the value of INT_MAX causing a integer overflow.
the API for both flatpak and package-kit return a unsigned 64 bit integer so that's what should be used.5.24https://invent.kde.org/plasma/discover/-/merge_requests/257flatpak: When it ends with .desktop, look up without .desktop instead2022-02-11T16:56:53ZAleix Pol Gonzalezflatpak: When it ends with .desktop, look up without .desktop insteadBUG: 414533BUG: 4145335.24https://invent.kde.org/plasma/discover/-/merge_requests/241Don't display critical packages/apps in the UI2022-02-10T18:06:27ZNate GrahamDon't display critical packages/apps in the UIRight now when the user clicks the Remove button for these, they'll get
a big ugly error message. Instead, we should just not show them in the
UI at all.
CCBUG: 449260Right now when the user clicks the Remove button for these, they'll get
a big ugly error message. Instead, we should just not show them in the
UI at all.
CCBUG: 4492605.24https://invent.kde.org/plasma/discover/-/merge_requests/256Implement Kirigami.CheckableListItem properly2022-02-08T20:18:06ZNate GrahamImplement Kirigami.CheckableListItem properlyWe don't need an action here, we just need to listen for when the
checked status changes.
BUG: 449766
FIXED-IN: 5.24.1We don't need an action here, we just need to listen for when the
checked status changes.
BUG: 449766
FIXED-IN: 5.24.15.24https://invent.kde.org/plasma/discover/-/merge_requests/253Polish the unattended updates trigger2022-02-08T00:29:10ZAleix Pol GonzalezPolish the unattended updates triggerMake sure we are only triggering when it actually makes sense.Make sure we are only triggering when it actually makes sense.5.24https://invent.kde.org/plasma/discover/-/merge_requests/165kns: Do not keep an own Attica::Provider2022-02-07T20:37:55ZAleix Pol Gonzalezkns: Do not keep an own Attica::ProviderInstead reuse the ones from the KNSCore::Engine we are already connected
through.
This allows us to reduce some workload, for example reducing the amount
of times the providers.xml file are downloaded.
Depends on https://invent.kde.org/...Instead reuse the ones from the KNSCore::Engine we are already connected
through.
This allows us to reduce some workload, for example reducing the amount
of times the providers.xml file are downloaded.
Depends on https://invent.kde.org/frameworks/knewstuff/-/merge_requests/1415.24https://invent.kde.org/plasma/discover/-/merge_requests/252ApplicationPage: Fix infinite resize loop on screenshoots2022-02-05T03:24:18ZAleix Pol GonzalezApplicationPage: Fix infinite resize loop on screenshootsWe were fitting it in height and it was freaking out whenever the
horizontal scrollbar appeared.
Now it depends on the ScrollView size instead of the ListView and so the
loop is broken.
BUG: 449583We were fitting it in height and it was freaking out whenever the
horizontal scrollbar appeared.
Now it depends on the ScrollView size instead of the ListView and so the
loop is broken.
BUG: 4495835.24