Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Discover
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Plasma
Discover
Commits
316cf301
Commit
316cf301
authored
Jan 26, 2018
by
Aleix Pol Gonzalez
🐧
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make AbstractResource::state() const
CCMAIL: Nate Graham <pointedstick@zoho.com>
parent
dccb04be
Changes
13
Hide whitespace changes
Inline
Side-by-side
Showing
13 changed files
with
16 additions
and
16 deletions
+16
-16
libdiscover/backends/DummyBackend/DummyResource.cpp
libdiscover/backends/DummyBackend/DummyResource.cpp
+1
-1
libdiscover/backends/DummyBackend/DummyResource.h
libdiscover/backends/DummyBackend/DummyResource.h
+1
-1
libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
+1
-1
libdiscover/backends/FlatpakBackend/FlatpakResource.h
libdiscover/backends/FlatpakBackend/FlatpakResource.h
+1
-1
libdiscover/backends/KNSBackend/KNSResource.cpp
libdiscover/backends/KNSBackend/KNSResource.cpp
+1
-1
libdiscover/backends/KNSBackend/KNSResource.h
libdiscover/backends/KNSBackend/KNSResource.h
+1
-1
libdiscover/backends/PackageKitBackend/LocalFilePKResource.h
libdiscover/backends/PackageKitBackend/LocalFilePKResource.h
+1
-1
libdiscover/backends/PackageKitBackend/PackageKitResource.cpp
...iscover/backends/PackageKitBackend/PackageKitResource.cpp
+1
-1
libdiscover/backends/PackageKitBackend/PackageKitResource.h
libdiscover/backends/PackageKitBackend/PackageKitResource.h
+1
-1
libdiscover/backends/SnapBackend/SnapResource.cpp
libdiscover/backends/SnapBackend/SnapResource.cpp
+1
-1
libdiscover/backends/SnapBackend/SnapResource.h
libdiscover/backends/SnapBackend/SnapResource.h
+1
-1
libdiscover/resources/AbstractResource.cpp
libdiscover/resources/AbstractResource.cpp
+2
-2
libdiscover/resources/AbstractResource.h
libdiscover/resources/AbstractResource.h
+3
-3
No files found.
libdiscover/backends/DummyBackend/DummyResource.cpp
View file @
316cf301
...
...
@@ -124,7 +124,7 @@ QString DummyResource::section()
return
QStringLiteral
(
"dummy"
);
}
AbstractResource
::
State
DummyResource
::
state
()
AbstractResource
::
State
DummyResource
::
state
()
const
{
return
m_state
;
}
...
...
libdiscover/backends/DummyBackend/DummyResource.h
View file @
316cf301
...
...
@@ -40,7 +40,7 @@ public:
int
size
()
override
;
QUrl
homepage
()
override
;
QStringList
categories
()
override
;
AbstractResource
::
State
state
()
override
;
AbstractResource
::
State
state
()
const
override
;
QVariant
icon
()
const
override
;
QString
comment
()
override
;
QString
name
()
override
;
...
...
libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
View file @
316cf301
...
...
@@ -344,7 +344,7 @@ QString FlatpakResource::sizeDescription()
}
}
AbstractResource
::
State
FlatpakResource
::
state
()
AbstractResource
::
State
FlatpakResource
::
state
()
const
{
return
m_state
;
}
...
...
libdiscover/backends/FlatpakBackend/FlatpakResource.h
View file @
316cf301
...
...
@@ -97,7 +97,7 @@ public:
QString
section
()
override
;
int
size
()
override
;
QString
sizeDescription
()
override
;
AbstractResource
::
State
state
()
override
;
AbstractResource
::
State
state
()
const
override
;
ResourceType
type
()
const
;
QString
typeAsString
()
const
;
QString
uniqueId
()
const
;
...
...
libdiscover/backends/KNSBackend/KNSResource.cpp
View file @
316cf301
...
...
@@ -37,7 +37,7 @@ KNSResource::KNSResource(const KNSCore::EntryInternal& entry, QStringList catego
KNSResource
::~
KNSResource
()
=
default
;
AbstractResource
::
State
KNSResource
::
state
()
AbstractResource
::
State
KNSResource
::
state
()
const
{
switch
(
m_entry
.
status
())
{
case
KNS3
::
Entry
::
Invalid
:
...
...
libdiscover/backends/KNSBackend/KNSResource.h
View file @
316cf301
...
...
@@ -35,7 +35,7 @@ public:
explicit
KNSResource
(
const
KNSCore
::
EntryInternal
&
c
,
QStringList
categories
,
KNSBackend
*
parent
);
~
KNSResource
()
override
;
AbstractResource
::
State
state
()
override
;
AbstractResource
::
State
state
()
const
override
;
QVariant
icon
()
const
override
;
QString
comment
()
override
;
QString
name
()
override
;
...
...
libdiscover/backends/PackageKitBackend/LocalFilePKResource.h
View file @
316cf301
...
...
@@ -32,7 +32,7 @@ class LocalFilePKResource : public PackageKitResource
QString
name
()
override
;
QString
comment
()
override
;
AbstractResource
::
State
state
()
override
{
return
m_state
;
}
AbstractResource
::
State
state
()
const
override
{
return
m_state
;
}
int
size
()
override
;
void
markInstalled
();
...
...
libdiscover/backends/PackageKitBackend/PackageKitResource.cpp
View file @
316cf301
...
...
@@ -130,7 +130,7 @@ QString PackageKitResource::section()
return
QString
();
}
AbstractResource
::
State
PackageKitResource
::
state
()
AbstractResource
::
State
PackageKitResource
::
state
()
const
{
if
(
backend
()
->
isPackageNameUpgradeable
(
this
))
return
Upgradeable
;
...
...
libdiscover/backends/PackageKitBackend/PackageKitResource.h
View file @
316cf301
...
...
@@ -47,7 +47,7 @@ class PackageKitResource : public AbstractResource
void
fetchChangelog
()
override
;
QList
<
PackageState
>
addonsInformation
()
override
;
State
state
()
override
;
State
state
()
const
override
;
QString
installedVersion
()
const
override
;
QString
availableVersion
()
const
override
;
...
...
libdiscover/backends/SnapBackend/SnapResource.cpp
View file @
316cf301
...
...
@@ -136,7 +136,7 @@ QString SnapResource::section()
return
QStringLiteral
(
"snap"
);
}
AbstractResource
::
State
SnapResource
::
state
()
AbstractResource
::
State
SnapResource
::
state
()
const
{
return
m_state
;
}
...
...
libdiscover/backends/SnapBackend/SnapResource.h
View file @
316cf301
...
...
@@ -44,7 +44,7 @@ public:
int
size
()
override
;
QUrl
homepage
()
override
;
QStringList
categories
()
override
;
AbstractResource
::
State
state
()
override
;
AbstractResource
::
State
state
()
const
override
;
QVariant
icon
()
const
override
;
QString
comment
()
override
;
QString
name
()
override
;
...
...
libdiscover/resources/AbstractResource.cpp
View file @
316cf301
...
...
@@ -53,12 +53,12 @@ QJsonValue AbstractResource::getMetadata(const QString &key)
return
m_metadata
.
value
(
key
);
}
bool
AbstractResource
::
canUpgrade
()
bool
AbstractResource
::
canUpgrade
()
const
{
return
state
()
==
Upgradeable
;
}
bool
AbstractResource
::
isInstalled
()
bool
AbstractResource
::
isInstalled
()
const
{
return
state
()
>=
Installed
;
}
...
...
libdiscover/resources/AbstractResource.h
View file @
316cf301
...
...
@@ -122,7 +122,7 @@ class DISCOVERCOMMON_EXPORT AbstractResource : public QObject
///executes the resource, if applies.
Q_SCRIPTABLE
virtual
void
invokeApplication
()
const
=
0
;
virtual
State
state
()
=
0
;
virtual
State
state
()
const
=
0
;
virtual
QStringList
categories
()
=
0
;
///@returns a URL that points to the content
...
...
@@ -154,8 +154,8 @@ class DISCOVERCOMMON_EXPORT AbstractResource : public QObject
void
addMetadata
(
const
QString
&
key
,
const
QJsonValue
&
value
);
QJsonValue
getMetadata
(
const
QString
&
key
);
bool
canUpgrade
();
bool
isInstalled
();
bool
canUpgrade
()
const
;
bool
isInstalled
()
const
;
///@returns a user-readable explaination of the resource status
///by default, it will specify what state() is returning
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment