Commit 5d254de6 authored by Nate Graham's avatar Nate Graham 🔩

[Updates page] Improve selected/unselected explanation view

Summary:
Improve the clarity of the information that's being displayed, reduce string length
so that wordy languages don't get anything cut off, and elide properly just in case
they do.

BUG: 404603
FIXED-IN: 5.16

Test Plan:
All updates selected: {F6626922, size=full}
Some Updates selected: {F6626923, size=full}
No updates selected: {F6626925, size=full}

Reviewers: #vdg, #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19192
parent e4eb734a
......@@ -105,23 +105,10 @@ DiscoverPage
}
}
LabelBackground {
text: updateModel.toUpdateCount + " (" + updateModel.updateSize+")"
}
Label {
text: i18n("updates selected")
}
LabelBackground {
id: unselectedItem
text: page.unselected
visible: page.unselected>0
}
Label {
text: i18n("updates not selected")
visible: unselectedItem.visible
}
Item {
Layout.fillWidth: true
text: (page.unselected === 0 ? i18n("All updates selected") : i18np("%1/%2 update selected", "%1/%2 updates selected", updateModel.toUpdateCount, updateModel.totalUpdatesCount)) + " (" + updateModel.updateSize + ")"
elide: Text.ElideRight
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment