Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Discover
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
2
Merge Requests
2
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Plasma
Discover
Commits
7202c8ed
Commit
7202c8ed
authored
Dec 11, 2017
by
Aleix Pol Gonzalez
🐧
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve error message when review dialog contents are wrong
BUG: 387261
parent
52f609be
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
6 deletions
+5
-6
discover/qml/ReviewDialog.qml
discover/qml/ReviewDialog.qml
+5
-6
No files found.
discover/qml/ReviewDialog.qml
View file @
7202c8ed
...
...
@@ -34,20 +34,19 @@ Kirigami.OverlaySheet
TextArea
{
id
:
reviewInput
property
bool
acceptableInput
:
false
readonly
property
bool
acceptableInput
:
inputIssue
.
count
===
0
readonly
property
string
inputIssue
:
length
<
15
?
i18n
(
"
Comment too short
"
)
:
length
>
3000
?
i18n
(
"
Comment too long
"
)
:
""
Layout.fillWidth
:
true
Layout.fillHeight
:
true
onLengthChanged
:
{
acceptableInput
=
length
>=
15
&&
length
<
3000
}
}
Button
{
id
:
acceptButton
Layout.alignment
:
Qt
.
AlignRight
enabled
:
summaryInput
.
acceptableInput
&&
reviewInput
.
acceptableInput
text
:
i18n
(
"
Accept
"
)
text
:
summaryInput
.
acceptableInput
&&
reviewInput
.
acceptableInput
?
i18n
(
"
Accept
"
)
:
!
summaryInput
.
acceptableInput
?
i18n
(
"
Improve summary
"
)
:
reviewInput
.
inputIssue
onClicked
:
{
reviewDialog
.
accepted
()
reviewDialog
.
sheetOpen
=
false
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment