Commit 732a0ffb authored by Nathaniel Graham's avatar Nathaniel Graham

Don't use a scrollview to display package changelogs

Summary:
BUG: 387036

Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details).

Also change the "Open" button to day "More Information..." since it wasn't clear what you were opening.

Test Plan:
Tested in KDE Neon. Package changelogs are now fully visible without being in a tiny scrollview:

{F5495553}

Reviewers: #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: abetts, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D8869
parent 485783c8
......@@ -194,15 +194,12 @@ DiscoverPage
}
}
ScrollView {
id: view
Layout.fillHeight: true
Layout.fillWidth: true
frameVisible: true
QQC2.Frame {
visible: layout.extended && changelog.length>0
QQC2.Label {
width: view.viewport.width
id: view
Layout.fillHeight: true
Layout.fillWidth: true
text: changelog
textFormat: Text.RichText
wrapMode: Text.WordWrap
......@@ -211,7 +208,7 @@ DiscoverPage
}
Button {
text: i18n("Open")
text: i18n("More Information...")
visible: layout.extended
enabled: !resourcesUpdatesModel.isProgressing
onClicked: Navigation.openApplication(resource)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment