Move TransactionSet into a separate file

libdiscover/backends/PackageKitBackend/CMakeLists.txt

@@ -12,6 +12,7 @@ add_library(packagekit-backend MODULE PackageKitBackend.cpp
     PackageKitMessages.cpp
     PackageKitSourcesBackend.cpp
     LocalFilePKResource.cpp
+    TransactionSet.cpp
 )
 target_link_libraries(packagekit-backend PRIVATE Discover::Common Qt5::Core PK::packagekitqt5 KF5::ConfigGui KF5::KIOCore KF5::Archive AppStreamQt)
 

libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

@@ -26,6 +26,7 @@
 #include "AppPackageKitResource.h"
 #include "PKTransaction.h"
 #include "LocalFilePKResource.h"
+#include "TransactionSet.h"
 #include <resources/AbstractResource.h>
 #include <resources/StandardBackendUpdater.h>
 #include <resources/SourcesModel.h>
@@ -212,38 +213,6 @@ AppPackageKitResource* PackageKitBackend::addComponent(const AppStream::Componen
     return res;
 }
 
-class TransactionSet : public QObject
-{
-    Q_OBJECT
-    public:
-        TransactionSet(const QVector<PackageKit::Transaction*> &transactions)
-            : m_transactions(transactions)
-        {
-            foreach(PackageKit::Transaction* t, transactions) {
-                connect(t, &PackageKit::Transaction::finished, this, &TransactionSet::transactionFinished);
-            }
-        }
-
-        void transactionFinished(PackageKit::Transaction::Exit exit) {
-            PackageKit::Transaction* t = qobject_cast<PackageKit::Transaction*>(sender());
-            if (exit != PackageKit::Transaction::ExitSuccess) {
-                qWarning() << "failed" << exit << t;
-            }
-
-            m_transactions.removeAll(t);
-            if (m_transactions.isEmpty()) {
-                Q_EMIT allFinished();
-            }
-        }
-
-    Q_SIGNALS:
-        void allFinished();
-
-    private:
-        QVector<PackageKit::Transaction*> m_transactions;
-
-};
-
 void PackageKitBackend::clearPackages(const QStringList& packageNames)
 {
     const auto resources = resourcesByPackageNames<QVector<AbstractResource*>>(packageNames);

libdiscover/backends/PackageKitBackend/TransactionSet.cpp

+/***************************************************************************
+ *   Copyright © 2017 Aleix Pol Gonzalez <aleixpol@blue-systems.com>       *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or         *
+ *   modify it under the terms of the GNU General Public License as        *
+ *   published by the Free Software Foundation; either version 2 of        *
+ *   the License or (at your option) version 3 or any later version        *
+ *   accepted by the membership of KDE e.V. (or its successor approved     *
+ *   by the membership of KDE e.V.), which shall act as a proxy            *
+ *   defined in Section 14 of version 3 of the license.                    *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
+ ***************************************************************************/
+
+#include "TransactionSet.h"
+
+#include <QDebug>
+
+TransactionSet::TransactionSet(const QVector<PackageKit::Transaction*> &transactions)
+    : m_transactions(transactions)
+{
+    foreach(PackageKit::Transaction* t, transactions) {
+        connect(t, &PackageKit::Transaction::finished, this, &TransactionSet::transactionFinished);
+    }
+}
+
+void TransactionSet::transactionFinished(PackageKit::Transaction::Exit exit)
+{
+    PackageKit::Transaction* t = qobject_cast<PackageKit::Transaction*>(sender());
+    if (exit != PackageKit::Transaction::ExitSuccess) {
+        qWarning() << "failed" << exit << t;
+    }
+
+    m_transactions.removeAll(t);
+    if (m_transactions.isEmpty()) {
+        Q_EMIT allFinished();
+        deleteLater();
+    }
+}

libdiscover/backends/PackageKitBackend/TransactionSet.h

+/***************************************************************************
+ *   Copyright © 2017 Aleix Pol Gonzalez <aleixpol@blue-systems.com>       *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or         *
+ *   modify it under the terms of the GNU General Public License as        *
+ *   published by the Free Software Foundation; either version 2 of        *
+ *   the License or (at your option) version 3 or any later version        *
+ *   accepted by the membership of KDE e.V. (or its successor approved     *
+ *   by the membership of KDE e.V.), which shall act as a proxy            *
+ *   defined in Section 14 of version 3 of the license.                    *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
+ ***************************************************************************/
+
+#ifndef TRANSACTIONSET_H
+#define TRANSACTIONSET_H
+
+#include <QObject>
+#include <QVector>
+#include <PackageKit/Transaction>
+
+class TransactionSet : public QObject
+{
+    Q_OBJECT
+    public:
+        TransactionSet(const QVector<PackageKit::Transaction*> &transactions);
+
+        void transactionFinished(PackageKit::Transaction::Exit exit);
+
+    Q_SIGNALS:
+        void allFinished();
+
+    private:
+        QVector<PackageKit::Transaction*> m_transactions;
+
+};
+
+#endif