Commit 9b0652d5 authored by Nate Graham's avatar Nate Graham 🔩

Improve layout and appearance of app details view

Summary:
After porting to FormLayout in D27183, the layout can now be so wide due to the URLs
that it switches to the compact/mobile view. This patch re-arranges things a bit and
uses human-readable strings for the links instead of showing raw URLs. For safety,
this requires D27663 to be implemented first.

BUG: 418019
FIXED-IN: 5.19.0
Depends on D27663

Test Plan:
Before: normal-sized window (shows the compact/mobile view): {F8131970}

Before wide window: {F8131971}

After: normal-sized or wide window: {F8131972}

Reviewers: #vdg, #discover_software_store, apol, ndavis

Reviewed By: #vdg, #discover_software_store, apol, ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27664
parent 6d6b7555
......@@ -384,25 +384,27 @@ DiscoverPage {
}
}
// Homepage row
// "User Guide" row
Kirigami.UrlButton {
Kirigami.FormData.label: i18n("Homepage:")
url: application.homepage
Kirigami.FormData.label: i18n ("Documentation:")
text: i18n("Read the user guide")
url: application.helpURL
Layout.fillWidth: true
horizontalAlignment: Text.AlignLeft
}
// "User Guide" row
// Homepage row
Kirigami.UrlButton {
Kirigami.FormData.label: i18n("User Guide:")
url: application.helpURL
Kirigami.FormData.label: i18n("Get involved:")
text: i18n("Visit the app's website")
url: application.homepage
Layout.fillWidth: true
horizontalAlignment: Text.AlignLeft
}
// Donate row
Kirigami.UrlButton {
Kirigami.FormData.label: i18n("Donate:")
text: i18n("Make a donation")
url: application.donationURL
Layout.fillWidth: true
horizontalAlignment: Text.AlignLeft
......@@ -410,7 +412,7 @@ DiscoverPage {
// "Report a Problem" row
Kirigami.UrlButton {
Kirigami.FormData.label: i18n("Report a Problem:")
text: i18n("Report a problem")
url: application.bugURL
Layout.fillWidth: true
horizontalAlignment: Text.AlignLeft
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment