Commit c73a0f5e authored by Marco Martin's avatar Marco Martin

don't override paddings

as paddings are used to indicate there should be some space
made up for the scrollbar, don't overwrite them, use negative
margins instead on the items we are sure there should never be
margins regarless the scrollbar is visible or not

Test Plan: better look both with and without scrollbars

Reviewers: apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision:
parent ed6f66ec
......@@ -29,9 +29,8 @@ import "navigation.js" as Navigation
Kirigami.GlobalDrawer {
id: drawer
bannerImageSource: "qrc:/banners/banner.svg"
topPadding: -50
leftPadding: 0
rightPadding: 0
//make the left and bottom margins for search field the same
topPadding: -searchField.height - leftPadding
bottomPadding: 0
resetMenuOnTriggered: false
......@@ -57,8 +56,6 @@ Kirigami.GlobalDrawer {
topContent: TextField {
id: searchField
Layout.fillWidth: true
Layout.leftMargin: Kirigami.Units.smallSpacing
Layout.rightMargin: Kirigami.Units.smallSpacing
enabled: window.leftPage && (window.leftPage.searchFor != null || window.leftPage.hasOwnProperty("search"))
Keys.forwardTo: [window.pageStack]
......@@ -107,6 +104,8 @@ Kirigami.GlobalDrawer {
ColumnLayout {
spacing: 0
Layout.fillWidth: true
Layout.leftMargin: -drawer.leftPadding
Layout.rightMargin: -drawer.rightPadding
Kirigami.Separator {
Layout.fillWidth: true
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment