Commit ee062be1 authored by Nate Graham's avatar Nate Graham 🔩

Polish Notifier Plasmoid's UI

Summary:
This patch implements the following changes to Discover's Update Notifier plasmoid:
- Improve the layout of the controls within the window
- Update the button text to reflect what it will actually do (the previous text was misleading since it did not in fact perform the updates; it just opened Discover)
- Update the tooltip text to be clearer
- Give the button an icon to match its plasmoid icon

Test Plan:
Before:
{F6121567}

After:
{F6122915}

Reviewers: apol, #discover_software_store, #vdg

Reviewed By: apol, #discover_software_store

Subscribers: fabianr, esedgh, broulik, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14238
parent 6fcc93f0
......@@ -23,32 +23,34 @@ import org.kde.plasma.extras 2.0 as PlasmaExtras
import org.kde.plasma.components 2.0
import org.kde.discovernotifier 1.0
ColumnLayout
{
Item {
PlasmaExtras.Heading {
Layout.fillWidth: true
anchors.top: parent.top
width: parent.width
level: 3
wrapMode: Text.WordWrap
text: DiscoverNotifier.message
}
Label {
visible: !DiscoverNotifier.isSystemUpToDate
Layout.fillWidth: true
Layout.fillHeight: true
wrapMode: Text.WordWrap
horizontalAlignment: Text.AlignHCenter
text: DiscoverNotifier.extendedMessage
}
Button {
visible: !DiscoverNotifier.isSystemUpToDate
Layout.alignment: Qt.AlignVCenter | Qt.AlignHCenter
text: i18n("Update")
tooltip: i18n("Launches the software to perform the update")
onClicked: DiscoverNotifier.showDiscoverUpdates()
}
Item {
Layout.fillHeight: true
width: 5
ColumnLayout {
anchors.horizontalCenter: parent.horizontalCenter
anchors.verticalCenter: parent.verticalCenter
spacing: units.smallSpacing * 2
Label {
visible: !DiscoverNotifier.isSystemUpToDate
Layout.fillWidth: true
wrapMode: Text.WordWrap
text: DiscoverNotifier.extendedMessage
}
Button {
visible: !DiscoverNotifier.isSystemUpToDate
Layout.alignment: Qt.AlignHCenter
iconSource: DiscoverNotifier.iconName
text: i18n("View Updates")
tooltip: i18n("Launches Discover to update the software")
onClicked: DiscoverNotifier.showDiscoverUpdates()
}
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment