Skip to content
  • Harald Sitter's avatar
    always support all command line options · abc37a6a
    Harald Sitter authored
    Summary:
    with the current way options are handled we'd always have a tight lock
    between kcrash and drkonqi making it unnecessarily difficult to add
    new options because newer kcrashes cannot simply pass them regardless of
    drkonqi's version.
    
    e.g.
    - drkonqi 5.20 adds --displayName
    - kcrash 5.70 adds support for passing --displayName
    - kcrash now needs to somehow determine the precise version of drkonqi
      because passing --displayName to 5.19 or below results in exit1
    
    by having drkonqi ignore unknown options we can eliminate this restriction
    as kcrash can then simply always pass all arguments it knows (which it
    needs to do for the entire so-series; 5.70 needs to still work with
    plasma 5.0 in theory)
    
    NB: 5.x still needs some variant of version checking as kcrash needs to
    find out if drkonqi has this new behavior. come 6.x we would be able to
    ignore versions entirely in kcrash
    
    Test Plan: passing arbitrary cli options no longer causes drkonqi to exit in error
    
    Reviewers: #plasma, apol
    
    Reviewed By: apol
    
    Subscribers: apol, plasma-devel
    
    Tags: #plasma
    
    Differential Revision: https://phabricator.kde.org/D19940
    abc37a6a