Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
DrKonqi
Commits
10d6bc79
Commit
10d6bc79
authored
Mar 23, 2022
by
Harald Sitter
🏳️🌈
Browse files
quit giving out the debugger from the generator
it's leaky abstraction and makes porting to qml a bit more annoying
parent
dc8579af
Pipeline
#154067
passed with stage
in 5 minutes and 41 seconds
Changes
3
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
src/backtracegenerator.cpp
View file @
10d6bc79
...
...
@@ -202,3 +202,13 @@ void BacktraceGenerator::setBackendPrepared()
m_proc
->
start
();
}
bool
BacktraceGenerator
::
debuggerIsGDB
()
const
{
return
m_debugger
.
codeName
()
==
QLatin1String
(
"gdb"
);
}
QString
BacktraceGenerator
::
debuggerName
()
const
{
return
m_debugger
.
displayName
();
}
src/backtracegenerator.h
View file @
10d6bc79
...
...
@@ -49,14 +49,12 @@ public:
return
m_parsedBacktrace
;
}
const
Debugger
debugger
()
const
{
return
m_debugger
;
}
// Called by manager when it is ready for us.
void
setBackendPrepared
();
Q_INVOKABLE
bool
debuggerIsGDB
()
const
;
Q_INVOKABLE
QString
debuggerName
()
const
;
public
Q_SLOTS
:
void
start
();
...
...
src/backtracewidget.cpp
View file @
10d6bc79
...
...
@@ -221,7 +221,7 @@ void BacktraceWidget::loadData()
}
// highlight if possible
if
(
m_btGenerator
->
debugger
().
codeName
()
==
QLatin1String
(
"gdb"
))
{
if
(
m_btGenerator
->
debugger
IsGDB
(
))
{
KSyntaxHighlighting
::
Repository
repository
;
m_highlighter
=
new
KSyntaxHighlighting
::
SyntaxHighlighter
(
ui
.
m_backtraceEdit
->
document
());
m_highlighter
->
setTheme
((
palette
().
color
(
QPalette
::
Base
).
lightness
()
<
128
)
?
repository
.
defaultTheme
(
KSyntaxHighlighting
::
Repository
::
DarkTheme
)
...
...
@@ -322,7 +322,7 @@ void BacktraceWidget::loadData()
"<strong>You need to first install the debugger "
"application (%1) then click the <interface>Reload"
"</interface> button.</strong>"
,
m_btGenerator
->
debugger
().
display
Name
()));
m_btGenerator
->
debuggerName
()));
}
ui
.
m_reloadBacktraceButton
->
setEnabled
(
true
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment