Commit 18d9420c authored by Harald Sitter's avatar Harald Sitter 🏳️‍🌈
Browse files

don't return bool from start

none of the callers actually look at it and the return value is blocking
refactoring towards a more async design where we block the gui thread
less
parent 42aca174
......@@ -48,7 +48,7 @@ BacktraceGenerator::~BacktraceGenerator()
}
}
bool BacktraceGenerator::start()
void BacktraceGenerator::start()
{
// they should always be null before entering this function.
Q_ASSERT(!m_proc);
......@@ -63,7 +63,7 @@ bool BacktraceGenerator::start()
qCWarning(DRKONQI_LOG) << "Debugger valid" << m_debugger.isValid() << "installed" << m_debugger.isInstalled();
m_state = FailedToStart;
emit failedToStart();
return false;
return;
}
m_proc = new KProcess;
......@@ -112,10 +112,7 @@ bool BacktraceGenerator::start()
m_state = FailedToStart;
emit failedToStart();
return false;
}
return true;
}
void BacktraceGenerator::slotReadInput()
......
......@@ -54,7 +54,7 @@ public:
}
public Q_SLOTS:
bool start();
void start();
Q_SIGNALS:
void starting();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment