Commit 3b8d672c authored by Harald Sitter's avatar Harald Sitter 🏳️‍🌈
Browse files

log why debugger entered failure state

we conveniently overload FailedToStart with also meaning IsNotInstalled
and IsNotValid making it impossible to tell what's wrong from just
looking at the GUI
parent 3c89fabc
......@@ -60,6 +60,7 @@ bool BacktraceGenerator::start()
emit starting();
if (!m_debugger.isValid() || !m_debugger.isInstalled()) {
qCWarning(DRKONQI_LOG) << "Debugger not valid" << m_debugger.isValid() << "not installed" << m_debugger.isInstalled();
m_state = FailedToStart;
emit failedToStart();
return false;
......@@ -101,6 +102,8 @@ bool BacktraceGenerator::start()
// FIXME: don't call wait functions on the GUI thread, instead connect to errorOcurred signal.
// Requires refactoring because this function returns a bool :|
if (!m_proc->waitForStarted()) {
qCWarning(DRKONQI_LOG) << "Debugger process failed to start" << m_proc->program() << m_proc->arguments() << m_proc->environment();
// we mustn't keep these around...
m_proc->deleteLater();
m_temp->deleteLater();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment