Commit 3c89fabc authored by Harald Sitter's avatar Harald Sitter 🏳️‍🌈
Browse files

add a fixme about the waitForStarted

qt docs explicitly say that it shouldn't be used on the gui thread, yet
we do :(
parent bb969bcf
......@@ -98,6 +98,8 @@ bool BacktraceGenerator::start()
connect(m_proc, static_cast<void (KProcess::*)(int, QProcess::ExitStatus)>(&KProcess::finished), this, &BacktraceGenerator::slotProcessExited);
m_proc->start();
// FIXME: don't call wait functions on the GUI thread, instead connect to errorOcurred signal.
// Requires refactoring because this function returns a bool :|
if (!m_proc->waitForStarted()) {
// we mustn't keep these around...
m_proc->deleteLater();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment