Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Plasma
DrKonqi
Commits
3c89fabc
Commit
3c89fabc
authored
Mar 04, 2021
by
Harald Sitter
🏳️🌈
Browse files
add a fixme about the waitForStarted
qt docs explicitly say that it shouldn't be used on the gui thread, yet we do :(
parent
bb969bcf
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/backtracegenerator.cpp
View file @
3c89fabc
...
...
@@ -98,6 +98,8 @@ bool BacktraceGenerator::start()
connect
(
m_proc
,
static_cast
<
void
(
KProcess
::*
)(
int
,
QProcess
::
ExitStatus
)
>
(
&
KProcess
::
finished
),
this
,
&
BacktraceGenerator
::
slotProcessExited
);
m_proc
->
start
();
// FIXME: don't call wait functions on the GUI thread, instead connect to errorOcurred signal.
// Requires refactoring because this function returns a bool :|
if
(
!
m_proc
->
waitForStarted
())
{
// we mustn't keep these around...
m_proc
->
deleteLater
();
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment