Commit e540b701 authored by Harald Sitter's avatar Harald Sitter 🏳️‍🌈
Browse files

try to fix qt6 build

also improve the test linkage while at it

instead of building bugzillalib twice we will simply use it from the
static ephemeral lib. saves time and also means the new drkonqi link
dependency is met
parent 5b4445b4
Pipeline #154259 passed with stage
in 4 minutes and 40 seconds
......@@ -83,7 +83,7 @@ void QMessageFilterContainer::clear()
BugzillaManager::BugzillaManager(const QString &bugTrackerUrl, QObject *parent)
: QObject(parent)
, m_bugTrackerUrl(bugTrackerUrl)
, m_bugTrackerUrl(bugTrackerUrl.isEmpty() ? KDE_BUGZILLA_URL : bugTrackerUrl)
{
Q_ASSERT(bugTrackerUrl.endsWith(QLatin1Char('/')));
Bugzilla::setConnection(new Bugzilla::HTTPConnection(QUrl(m_bugTrackerUrl + QStringLiteral("rest"))));
......
......@@ -32,7 +32,7 @@ class BugzillaManager : public QObject
public:
// Note: it expect the bugTrackerUrl parameter to contain the trailing slash.
// so it should be "https://bugs.kde.org/", not "https://bugs.kde.org"
explicit BugzillaManager(const QString &bugTrackerUrl = KDE_BUGZILLA_URL, QObject *parent = nullptr);
explicit BugzillaManager(const QString &bugTrackerUrl = QString(), QObject *parent = nullptr);
/* Login methods */
Q_SCRIPTABLE void tryLogin(const QString &username, const QString &password);
......
set(bugzillalibtest_SRCS bugzillalibtest.cpp ../../bugzillaintegration/bugzillalib.cpp)
set(bugzillalibtest_SRCS bugzillalibtest.cpp)
ecm_qt_declare_logging_category(
bugzillalibtest_SRCS
......@@ -10,4 +10,4 @@ ecm_qt_declare_logging_category(
add_executable(bugzillalibtest ${bugzillalibtest_SRCS})
ecm_mark_as_test(bugzillalibtest)
target_link_libraries(bugzillalibtest KF5::KIOWidgets KF5::I18n qbugzilla)
target_link_libraries(bugzillalibtest KF5::KIOWidgets KF5::I18n qbugzilla DrKonqiInternal)
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment