1. 07 Nov, 2019 1 commit
    • Harald Sitter's avatar
      unbreak crash reports involving QML · 0f343ffb
      Harald Sitter authored
      memfd files for QML JIT are /memfd:JITCode:/path/to/libQt5Qml.so.5 which
      results in false positives for the deletion regex we use to detect
      updated software
      0f343ffb
  2. 06 Nov, 2019 1 commit
  3. 05 Nov, 2019 1 commit
    • Harald Sitter's avatar
      disable bug report when there are signs of an update · 210c9d88
      Harald Sitter authored
      Summary:
      this actually improves UX more than anything. when there was an update it
      is fairly impossible to install debug symbols, so drkonqi may get stuck in
      a loop between saying this crash is garbage and suggesting the user install
      some more symbols. what's more is that the crash can be the result
      of incompatibilities in runtime-loaded plugins (a notorious example are
      KIO slaves, which get forked from klauncher which I think can lead
      to problems when loading the newer libQt5Core.so etc.).
      
      all in all crashes coming from a half-update runtime are hard to trace
      and also at risk of being worthless. so, instead disable the report and
      the install symbols features and inform the user about what
      went wrong in both cases.
      
      this is pretty much exclusively working for linux where the kernel will
      actually add " (deleted)" hints to all symlinks in procfs and have a
      map_files directory where all mmap'd regions are symlinked to their
      respective paths... also with that suffix as needed.
      
      the way it works is super easy: iter all map_files, get all deleted paths,
      make sure none of the .so or the executable itself are marked deleted.
      if anything is marked deleted, the report feature gets disabled
      
      Test Plan: update dolphin -> attach drkonqi -> drkonqi whines about dolphin being updated
      
      Reviewers: #plasma, apol
      
      Reviewed By: apol
      
      Subscribers: apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25002
      210c9d88
  4. 04 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · 5599273f
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      5599273f
  5. 31 Oct, 2019 1 commit
  6. 23 Oct, 2019 3 commits
  7. 22 Oct, 2019 1 commit
  8. 13 Oct, 2019 1 commit
  9. 10 Oct, 2019 3 commits
  10. 25 Sep, 2019 3 commits
    • Harald Sitter's avatar
      Merge branch 'Plasma/5.17' · 6bef8840
      Harald Sitter authored
      6bef8840
    • Harald Sitter's avatar
      fix default version selection to allow for renamed "unspecified" versions · b769764b
      Harald Sitter authored
      Summary:
      plasmashell for example has a "master" instead of "unspecified". if we
      still tried to file a bug against "unspecified" bugzilla will throw rather
      unhelpful errors. instead as a fallback to finding a "proper" version, make
      sure to set the "default" to something sane. if the hardcoded default
      doesn't map to an actual version as per the API we pick the lowest possible
      id and file against that instead. seeing as you cannot remove versions this
      should technically be the "unspecified" version no matter what it was
      renamed to.
      
      BUG: 411983
      
      Test Plan: can file bugs against plasmashell even when kcrash passed an empty or unmapped version
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24214
      b769764b
    • Harald Sitter's avatar
      use KBusyIndicatorWidget for all busy indication uses · 871ed0a9
      Harald Sitter authored
      Summary:
      unlike the pixmapsequence this scales properly and is actually theme color
      sensitive (contrast on dark themes) and looks nicely integrated into plasma
      
      Test Plan: triggered all possible busy indicators and they look dandy
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24158
      871ed0a9
  11. 19 Sep, 2019 2 commits
  12. 18 Sep, 2019 1 commit
  13. 16 Sep, 2019 1 commit
  14. 11 Sep, 2019 1 commit
  15. 04 Sep, 2019 1 commit
  16. 26 Aug, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Add option to discourage reporting bugs · 81c4e8f5
      Kai Uwe Broulik authored
      This is for vendors and environments that don't want to allow their users to report bugs directly to us.
      By setting InteractionAllowed to false in drkonqirc the following will change:
      
      * For automatically restarted services, no hint is shown whatsoever
      * On shutdown no hint is shown whatsoever
      * For application crashes a notification is shown with a Restart button but no status icon nor "Report bug" button
      
      The DrKonqi dialog itself is unchanged (for now?), which will show up in the rare case no notification service is running.
      Also removed the icon name stuff that clearly never worked.
      
      Differential Revision: https://phabricator.kde.org/D23261
      81c4e8f5
  17. 24 Aug, 2019 1 commit
  18. 16 Aug, 2019 1 commit
  19. 14 Aug, 2019 2 commits
  20. 12 Aug, 2019 4 commits
  21. 08 Aug, 2019 1 commit
  22. 30 Jul, 2019 1 commit
  23. 23 Jul, 2019 2 commits
    • Harald Sitter's avatar
      Merge branch 'Plasma/5.16' · e264b50a
      Harald Sitter authored
      # Conflicts:
      #	CMakeLists.txt
      e264b50a
    • Harald Sitter's avatar
      guard against plasmashell being properly dead and not showing the SNI · 3eeb0ce5
      Harald Sitter authored
      Summary:
      when plasmashell is particularly dead and not even able to restart, the SNI
      host may still be around when we check for it in the main.cpp as its
      disappearance from dbus is tied to sockets closing and dbus' event loop
      reacting to that. so there is a race potential that can cause the SNI
      to not actually be visible on account of the SNI host (plasmashell)
      being dead even though we expected SNI support to be available.
      
      guard against this scenario by starting an automatic activation timer
      when the notification service disappears. should it not reappear within
      10 second we consider it dead and show the dialog automatically as the
      user won't be seeing the SNI anymore
      
      Possibly fixing
      CCBUG: 383863
      
      Test Plan:
      - crash something so the sni appears
      - kill plasma
      - wait 10s
      - dialog appears
      
      - same again
      - restart plasma before 10s have passed
      - sni appears again in plasmashell
      
      Reviewers: #plasma
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22553
      3eeb0ce5
  24. 20 Jul, 2019 2 commits
  25. 19 Jul, 2019 2 commits
    • Harald Sitter's avatar
      pull platforms/distributions dynamically out of the bugzilla api · bc83d5ba
      Harald Sitter authored
      Summary:
      this ensures that all known platforms are actually in the comobox and
      reduces the amount of string duplication.
      
      the new code gets the list of platforms from bugzilla and then either
      attempts to select the one which was auto-detected by systeminformation
      or recycle the one previously used.
      
      setup is now triggered in the constructor. loading from the api is still
      fairly cheap but even so takes longer than the hardcoded list, so
      loading this on aboutToShow is fairly unattractive at this point.
      
      the now useless members for combobox state tracking are gone entirely.
      
      BUG: 383530
      CHANGELOG: The list of available platforms is now always in sync with the list on bugzilla itself
      
      Test Plan:
      list gets loaded as expected
      list errors as expected when offline
      
      Reviewers: #plasma, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22492
      bc83d5ba
    • Harald Sitter's avatar
      implement parts of the bug field api endpoint · a8f050c6
      Harald Sitter authored
      Summary:
      excessively unnecessary properties are not mapped currently as the only
      use we have for this endpoint is to get the list of remotely known
      platforms/distros. this may change in the future of course.
      
      Test Plan: unit test passes
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D22491
      a8f050c6
  26. 16 Jul, 2019 1 commit