1. 12 Dec, 2020 1 commit
    • Christoph Roick's avatar
      Modify DBus service name to allow using QDBusServiceWatcher · 243461e9
      Christoph Roick authored
      Fix the DBus connection which allows passing a debuggee to one of the
      KDevelop debuggers for future versions (>=5.7) of KDevelop. Instead of the
      deprecated serviceOwnerChanged signal, a QDBusServiceWatcher is used,
      which requires a different naming scheme. See KDevelop commit 69ef7ea8.
      
      This change has no impact on the connection with current versions of KDevelop.
      243461e9
  2. 11 Nov, 2020 2 commits
  3. 05 Nov, 2020 1 commit
  4. 03 Nov, 2020 1 commit
    • Harald Sitter's avatar
      fix buttongroup state toggles · b21006b7
      Harald Sitter authored
      this was recently changed on the BugAwarenessPage and broke state
      tracking as idPressed is emitted when pressing down, before the group
      state actually switches. the yes/no group on that page was effectively
      inverted as updateCheckBoxes was called before the property update and
      thus when the user clicked Yes the internal state in the slot was still
      No and vice versa.
      
      the duplicates dialog similarly was wrong but it's much harder to
      stumble over since the relevant UI elements are only visible when trying
      to mark a bug duplicate to a closed bug or a "common" bug
      
      use the idClicked signal instead, it's what the code originally used (as
      the now deprecated buttonClicked)
      
      BUG: 428346
      b21006b7
  5. 31 Oct, 2020 1 commit
  6. 29 Oct, 2020 1 commit
  7. 23 Oct, 2020 1 commit
  8. 22 Oct, 2020 6 commits
  9. 03 Oct, 2020 1 commit
  10. 24 Sep, 2020 1 commit
  11. 21 Sep, 2020 2 commits
  12. 20 Sep, 2020 1 commit
  13. 17 Sep, 2020 3 commits
  14. 16 Sep, 2020 1 commit
  15. 31 Aug, 2020 1 commit
  16. 17 Aug, 2020 2 commits
    • Ahmad Samir's avatar
      Fix the port to QRegularExpression · 7d2cfbe4
      Ahmad Samir authored
      I made some mistakes when porting from QRegExp to QRegularExpression:
      - With QRegularExpression::DotMatchesEverythingOption enabled, better use
        QRegularExpression::anchoredPattern and not rely on "^" and "$" to anchor
        the pattern (anchoredPattern uses "\A" and "\z" which is more accurate/precise)
      - Disable QRegularExpression::DotMatchesEverythingOption before subsequent
        setPattern calls, it's only needed for the first matching
      - When calling setPattern, obviously the previous QRegularExpression::anchoredPattern
        isn't going to be in effect, call it again if you want the pattern to be
        anchored
      
      Thanks to sitter for the unit tests that exposed the issue, and for
      spotting the issue with needing to anchor the pattern.
      
      All unit tests pass.
      7d2cfbe4
    • Harald Sitter's avatar
      add gdb line test for thread start and current thread markers · 7512f620
      Harald Sitter authored
      these tests do not presently pass because they regressed in the
      qregularexpression port 8d8062fe
      
      as for exmaple observed in https://bugs.kde.org/show_bug.cgi?id=423222
      which lacks the marker lines
      
      at a glance exactMatch->hasMatch wasn't a good port and so the line
      falls into the CRAP regex' `0x[0-9a-f]+.*|` which would match line
      containing a hex number
      7512f620
  17. 10 Aug, 2020 1 commit
  18. 08 Jul, 2020 1 commit
  19. 18 Jun, 2020 1 commit
  20. 17 Jun, 2020 1 commit
  21. 08 Jun, 2020 2 commits
  22. 03 Jun, 2020 1 commit
  23. 31 May, 2020 1 commit
  24. 17 May, 2020 1 commit
  25. 14 May, 2020 2 commits
  26. 12 May, 2020 2 commits
    • Harald Sitter's avatar
      Merge branch 'Plasma/5.18' · 85aa2616
      Harald Sitter authored
      # Conflicts:
      #	CMakeLists.txt
      85aa2616
    • Harald Sitter's avatar
      initialize bools to false by default · c517b795
      Harald Sitter authored
      Summary:
      This should fix random 113 errors (user_not_insider) coming out of the api
      
      I can't really reproduce the problem other than by setting the bools
      explicitly to true. Seeing as they were previously not set explicitly
      they could very well end up true accidentally.
      To fix this let's set them explicitly false.
      
      BUG: 421187
      FIXED-IN: 5.18.6
      
      Test Plan:
      hoping for the best!
      tests still pass tho
      
      Reviewers: davidedmundson, apol
      
      Reviewed By: apol
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D29675
      c517b795
  27. 05 May, 2020 1 commit