Commit dd95de33 authored by Daniel Vrátil's avatar Daniel Vrátil 🤖

Fix the 'Report bug' button being always disabled

Summary:
The commit d4ae04a7 has changed #define of HAVE_XMLRPCLCIENT
to #cmakedefine01 - since HAVE_XMLRPCCLIENT is not defined anywhere
in the CMakeFiles.txt, this lead to the 'Report bug' button being
unconditionally disabled at compile time.

Since KXmlRpcClient is a REQUIRED dependency (and has been for a while),
we can just remove the macro altogether.

BUG: 406606
FIXED-IN: 5.16.0

Test Plan: The 'Report bug' button is enabled

Reviewers: dfaure

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21527
parent f6518688
#cmakedefine01 HAVE_STRSIGNAL
#cmakedefine01 HAVE_UNAME
#cmakedefine01 HAVE_X11
#cmakedefine01 HAVE_XMLRPCCLIENT
#define DEBUG_PACKAGE_INSTALLER_NAME "@DEBUG_PACKAGE_INSTALLER_NAME@"
......
......@@ -39,9 +39,7 @@
#include "debuggerlaunchers.h"
#include "drkonqi_globals.h"
#include "config-drkonqi.h"
#if HAVE_XMLRPCCLIENT
#include "bugzillaintegration/reportassistantdialog.h"
#endif
#include "bugzillaintegration/reportassistantdialog.h"
static const char ABOUT_BUG_REPORTING_URL[] = "#aboutbugreporting";
static QString DRKONQI_REPORT_BUG_URL = KDE_BUGZILLA_URL + QStringLiteral("enter_bug.cgi?product=drkonqi&format=guided");
......@@ -185,8 +183,7 @@ void DrKonqiDialog::buildDialogButtons()
bool enableReportAssistant = !crashedApp->bugReportAddress().isEmpty() &&
crashedApp->fakeExecutableBaseName() != QLatin1String("drkonqi") &&
!DrKonqi::isSafer() &&
HAVE_XMLRPCCLIENT;
!DrKonqi::isSafer();
reportButton->setEnabled(enableReportAssistant);
connect(reportButton, &QPushButton::clicked, this, &DrKonqiDialog::startBugReportAssistant);
......@@ -267,13 +264,11 @@ void DrKonqiDialog::enableDebugMenu(bool debuggerRunning)
void DrKonqiDialog::startBugReportAssistant()
{
#if HAVE_XMLRPCCLIENT
ReportAssistantDialog * bugReportAssistant = new ReportAssistantDialog();
bugReportAssistant->show();
connect(bugReportAssistant, &QObject::destroyed, this, &DrKonqiDialog::reject);
hide();
#endif
}
void DrKonqiDialog::linkActivated(const QString& link)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment