1. 02 Dec, 2019 1 commit
    • Mikhail Zolotukhin's avatar
      Remove unneeded options in GTK KCM · e3274dba
      Mikhail Zolotukhin authored
      Summary:
      Since font, icons, cursor theme, toolbar style, icons in menus and buttons settings are now in sync with corresponding plasma settings, they shouldn't be in GTK KCM anymore.
      
      Depends on D24743
      
      BUG: 406740
      
      BUG: 401008
      
      BUG: 401123
      
      FIXED-IN: 5.18.0
      
      Test Plan:
      Check if nothing breaks in GTK KCM functionality, that is left.
      
      {F7617327}
      
      {F7693105}
      
      Reviewers: #vdg, #plasma, ngraham, nicolasfella
      
      Reviewed By: #vdg, ngraham, nicolasfella
      
      Subscribers: apol, ngraham, broulik, filipf, GB_2, plasma-devel
      
      Tags: #plasma, #vdg
      
      Maniphest Tasks: T10611
      
      Differential Revision: https://phabricator.kde.org/D24744
      e3274dba
  2. 28 Nov, 2019 1 commit
  3. 27 Nov, 2019 1 commit
  4. 25 Nov, 2019 1 commit
  5. 23 Nov, 2019 1 commit
  6. 22 Nov, 2019 1 commit
  7. 21 Nov, 2019 1 commit
  8. 20 Nov, 2019 1 commit
  9. 18 Nov, 2019 1 commit
  10. 17 Nov, 2019 1 commit
  11. 16 Nov, 2019 1 commit
  12. 15 Nov, 2019 1 commit
  13. 14 Nov, 2019 1 commit
    • Mikhail Zolotukhin's avatar
      Update GTK settings according to Plasma settings · 94732eb8
      Mikhail Zolotukhin authored
      Summary:
      To increase usability,
      
      - fonts
      - icon theme
      - cursor theme
      - toolbar style (icons-only, text below buttons etc)
      - icons visibility in menus
      - icons visibility on buttons
      
      settings for gtk applications are now set in respective kcms, instead of separate gtk kcm.
      
      Various kcms are sending signals (dbus or Qt ones) about the configuration change. Then the gtkconfig kded daemon connects to these signals and changes gtk config files to match new settings, that were set in those kcms.
      
      D24701 is needed to notify about cursor change on Wayland.
      
      Live reloading (on a fly) is not going to work for some settings on X11. This applies to cursor theme, it's changed by partially. To illustrate that open Nautilus File Manager, change cursor theme and try to double click folders. You will see, that "loading" cursor changed its theme, but "idle" one did not.
      
      What is not tested:
      - Toolbar style for gtk3 apps other that Geany (absence of live reloading may be a Geany bug)
      - Toolbar style and icons visibility on Wayland
      
      Depends on D24701
      
      BUG: 401507
      
      BUG: 375272
      
      BUG: 411097
      
      FIXED-IN: 5.18.0
      
      Test Plan:
      # To test gtk3 applications live reloading on X11, install xsettingsd.
      # Restart kded5.
      # Open gtk2 app, gtk3 app
      # Change above mentioned settings in respective KCMs
      # Check if gtk applications are changing their settings before (sometimes) and after their restart.
      
      Rare cases:
      - To test icons on buttons use Inkscape about window.
      - To test toolbar style use Geany (gtk3, live reloading does not work) and BleachBit (gtk2)
      
      Reviewers: #plasma, #vdg, broulik, cblack
      
      Reviewed By: #plasma, broulik
      
      Subscribers: ervin, ngraham, broulik, nicolasfella, plasma-devel
      
      Tags: #plasma, #vdg
      
      Maniphest Tasks: T10611
      
      Differential Revision: https://phabricator.kde.org/D24743
      94732eb8
  14. 09 Nov, 2019 1 commit
  15. 07 Nov, 2019 2 commits
    • Nate Graham's avatar
      Merge branch 'Plasma/5.17' · 6fa37e96
      Nate Graham authored
      6fa37e96
    • Mikhail Zolotukhin's avatar
      Remove gtkrc-2.0 legacy settings · 308342b1
      Mikhail Zolotukhin authored
      Summary:
      Previously GTK KCM wrote to gtkrc redundant settings lines:
      # `include "path to chosen gtk2 theme"`
      #
      ```
      style "user-font"
      {
      font-name="whatever font was chosen"
      }
      widget_style "*" style "user-font"
      ```
      
      Now GTK KCM does not write those lines to configuration file,
      but ones that was kept from previous versions of KCM
      are causing various glitches, when applying gtk2
      configuration, for theme and font configs respectively.
      
      This patch fixes these issues removing these lines from gtkrc
      by force, after applying any configuration from GTK KCM.
      
      BUG: 413678
      
      BUG: 413107
      
      Test Plan:
       # Open ~/gtkrc-2.0 and add those lines (theme and font name are arbitrary):
      ```
      include "/usr/share/themes/Adwaita-dark/gtk-2.0/gtkrc"
      style "user-font"
      {
          font_name="Noto Sans Regular"
      }
      widget_class "*" style "user-font"
      ```
      # Open GTK KCM and apply any configuration
      # Reopen ~/gtkrc-2.0 file and check, that those lines were removed
      
      Reviewers: cblack, #plasma, apol, ngraham
      
      Reviewed By: cblack, ngraham
      
      Subscribers: ervin, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25147
      308342b1
  16. 05 Nov, 2019 1 commit
  17. 04 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · 59ad3f60
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      59ad3f60
  18. 31 Oct, 2019 1 commit
  19. 29 Oct, 2019 1 commit
  20. 22 Oct, 2019 1 commit
  21. 20 Oct, 2019 2 commits
  22. 10 Oct, 2019 3 commits
  23. 27 Sep, 2019 1 commit
  24. 26 Sep, 2019 1 commit
  25. 19 Sep, 2019 4 commits
  26. 24 Aug, 2019 5 commits
    • Antonio Rojas's avatar
      6b1ec10f
    • Antonio Rojas's avatar
      Fix build with pango 1.44 · cf8db4eb
      Antonio Rojas authored
      pango>=1.44 headers depend on harfbuzz ones, make sure cmake can find them and pass the right include dir to the compiler
      
      Differential Revision: https://phabricator.kde.org/D22832
      cf8db4eb
    • Mikhail Zolotukhin's avatar
      Keep existing configurations' strings                · a9f3a3dd
      Mikhail Zolotukhin authored
      Summary:
      Gtk configurator has been replacing .gtkrc-2.0 config file with it's own settings, discarding present file contents. Now it only modifies configuration strings, or add them if they are not present at the beginning of the file.
      
      This patch also removes redundant configurations, such as including theme from /usr/share/themes gtkrc's, "user-font" style, widget_class and unneeded symlink .gtkrc-2.0-kde4. Those options do not seem needed, as gtk2 applications look the same without these options without any regressions. This was tested on Gimp, Inkscape and BleachBit apps on Manjaro, OpenSUSE and KDE Neon distributions.
      
      As for gtk3 ini file - this is not reproducible anymore, any line, which does not hold parameter changeable in configurator, remains in settings.ini.
      
      BUG: 322797
      BUG: 354963
      BUG: 342320
      FIXED-IN: 5.17.0
      
      Test Plan:
      Insert some lines in .gtkrc-2.0 file, that do not represent settings, that configurator changes, check if they are still present after applying new settings.
      
      Check if gtk2 apps look identical with or without .gtkrc-2.0-kde4 symlink, with or without similar lines in .gtrkrc-2.0:
      
      ```
      include "/usr/share/themes/Breeze/gtk-2.0/gtkrc"
      style "user-font"
      {
      	font_name="Noto Sans Regular"
      }
      widget_class "*" style "user-font"
      
      ```
      
      Reviewers: apol, #plasma
      
      Reviewed By: apol
      
      Subscribers: GB_2, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21524
      a9f3a3dd
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 22910941
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      22910941
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · dfc8e202
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      dfc8e202
  27. 30 Jul, 2019 1 commit
  28. 13 Jul, 2019 1 commit
  29. 09 Jul, 2019 1 commit