Commit 442cf697 authored by Friedrich W. H. Kossebau's avatar Friedrich W. H. Kossebau
Browse files

Use consistent spacing and units for suffixes in spinboxes

Summary:
As specified by the International System of Units (SI) there is usually a
space between the number and the unit (symbol). To still allow localisations
to apply some custom appendix of the unit, the separating space is part of the
string to translate.

For common units like seconds and minutes the SI symbols "s" & "min" are
used, while for others more explicit terms are used ("days", "strips per
comic").

Reviewers: #plasma, #localization, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: aacid, davidedmundson, plasma-devel

Tags: #plasma, #localization

Differential Revision: https://phabricator.kde.org/D12137
parent 0f24aa7d
......@@ -61,7 +61,7 @@ Item {
Controls.SpinBox {
id: maxComicLimit
Layouts.Layout.minimumWidth: units.gridUnit * 8
suffix: " "+i18n("strips per comic")
suffix: i18nc("spacing to number + unit", " strips per comic")
stepSize: 1
onValueChanged: root.configurationChanged();
}
......
......@@ -112,7 +112,7 @@ Item {
Controls.SpinBox {
id: providerUpdateInterval
Layouts.Layout.minimumWidth: units.gridUnit * 8
suffix: " "+i18n("days")
suffix: i18nc("spacing to number + unit", " days")
stepSize: 1
onValueChanged: root.configurationChanged();
}
......@@ -125,7 +125,7 @@ Item {
Controls.SpinBox {
id: checkNewComicStripsInterval
Layouts.Layout.minimumWidth: units.gridUnit * 8
suffix: " "+i18n("minutes")
suffix: i18nc("spacing to number + unit (minutes)", " min")
stepSize: 1
onValueChanged: root.configurationChanged();
}
......
......@@ -56,7 +56,7 @@ ColumnLayout {
id: intervalSpinBox
Layout.row: 0
Layout.column: 1
suffix: i18n("s")
suffix: i18nc("spacing to number + unit (seconds)", " s")
decimals: 1
// Once a day should be high enough
......
......@@ -128,7 +128,7 @@ Item {
decimals: 1
stepSize: 0.1
minimumValue: 0.1
suffix: i18nc("Abbreviation for seconds", "s")
suffix: i18nc("spacing to number + unit (seconds)", " s")
}
}
......
......@@ -211,7 +211,7 @@ ColumnLayout {
Layout.row: 3
Layout.column: 1
Layout.minimumWidth: units.gridUnit * 8
suffix: i18n(" min")
suffix: i18nc("spacing to number + unit (minutes)", " min")
stepSize: 5
minimumValue: 30
maximumValue: 3600
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment