Improve linking interface metadata of libplasmaweatherprivate

applets/weather/CMakeLists.txt

 add_definitions(-DTRANSLATION_DOMAIN=\"plasma_applet_org.kde.plasma.weather\")
 
-include_directories(
-    ${CMAKE_SOURCE_DIR}/libs
-)
-
 set(weatherapplet_SRCS
     weatherapplet.cpp)
 
@@ -16,6 +12,7 @@ target_link_libraries(plasma_applet_weather
     KF5::Plasma
     KF5::UnitConversion
     KF5::IconThemes
+    KF5::I18n
 )
 
 install(TARGETS plasma_applet_weather DESTINATION ${PLUGIN_INSTALL_DIR}/plasma/applets)

libs/plasmaweather/CMakeLists.txt

@@ -22,8 +22,10 @@ add_library(plasmaweather SHARED ${plasmaweather_LIB_SRCS})
 generate_export_header(plasmaweather)
 
 target_link_libraries(plasmaweather
+PUBLIC
     KF5::Plasma
     KF5::UnitConversion
+PRIVATE
     KF5::WidgetsAddons
     KF5::Notifications
     KF5::I18n
@@ -31,6 +33,7 @@ target_link_libraries(plasmaweather
 set_target_properties(plasmaweather PROPERTIES
     OUTPUT_NAME plasmaweatherprivate
 )
+target_include_directories(plasmaweather INTERFACE "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/..>")
 
 install(TARGETS plasmaweather ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
 # nothing outside of kdeplasma-addons uses this library, and the API is not stable -> do not install headers!