- 18 Apr, 2018 8 commits
-
-
Friedrich W. H. Kossebau authored
Fixup for f3ad84f9
-
Friedrich W. H. Kossebau authored
Summary: Applets which need initial configuration display some centered button to noth indicate the status as well as help the user to quickly get to the configuration page. Having consistent text on those buttons improves UX. Reviewers: #plasma, broulik Reviewed By: #plasma, broulik Subscribers: broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12313
-
Friedrich W. H. Kossebau authored
Summary: For a consistent UX use the same component for config UI elements showing a currently selected color and allowing to trigger a color picker to select another color. Test Plan: All buttons adapt to color changes as well as trigger the color dialog if activated and take over any chosen color. Reviewers: #plasma, #vdg, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: davidedmundson, ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12318
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
Summary: Especially with some translations the text will not fit on a single line. BUG: 393232 Reviewers: #plasma, aspotashev Reviewed By: aspotashev Subscribers: aspotashev, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12307
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 17 Apr, 2018 6 commits
-
-
Friedrich W. H. Kossebau authored
Summary: Depends: D12287 Test Plan: Dropping an image file (of listed MIME type) or a folder adds the Media Frame widget to list of widgets proposed to be added for that file/folder, selecting it then creates an instance with the given file/folder being set as source. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12288
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
Summary: It was broken for 2 reasons: * usage of since-renamed MediaFrame::has() method * calling push() directly on plasmoid.configuration.pathList was no-op due to QTBUG-67773 Test Plan: Dropping files & folders onto an existing mediaframe widget results in the files & folders being added now. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12287
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
Summary: "comboBoxItems" does not reference anything, at least after 2700c2f7 Instead the model of the combobox created by JS due to i18n() calls needs to be indirectly referenced. To not only avoid some race condition during setup, text of the fillModeDescription label is now set by a binding, instead of being manually set in onCurrentIndexChanged handler of the combobox Test Plan: Description of fill mode is now correct on initial config page view. Selecting another fill mode results in update of the description. Selecting another fill mode now also actually works. Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12134
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 16 Apr, 2018 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 15 Apr, 2018 7 commits
-
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 14 Apr, 2018 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 13 Apr, 2018 1 commit
-
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
- 12 Apr, 2018 6 commits
-
-
Friedrich W. H. Kossebau authored
Summary: Installing the headers of libplasmapotdprovidercore in the include namespace plasma/potdprovider as well as some CMake Config files of the name PlasmaPotdProvider allows it 3rd-party to develop own potd provider plugins without having to mess with the complete kdeplasma-addons repo. A potd-provider plugin template in kapptemplate format should speed up development of new plugins some more. Test Plan: Generated a new plugin from the template, built and installed it, selected it in the POTD wallpaper and got the KDE logo as fetched from techbase shown. Reviewers: xuetianweng Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11964
-
Friedrich W. H. Kossebau authored
Summary: The desktop files are only used at buildtime, so given the existing support of scripty for plugin metadata JSON files, no need for the additional format conversion during the build. Test Plan: All plugins still load and build. Reviewers: xuetianweng Subscribers: ltoscano, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11954
-
Friedrich W. H. Kossebau authored
Summary: There is no need to use pimpl for non-public-API classes. While touching the code, also change to use consistently modern signal-slot connections. Test Plan: All plugins still build, load & work as before. Reviewers: xuetianweng Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11957
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
Summary: The used service no longer existed. While the pointers listed e.g. at https://commons.wikimedia.org/wiki/Commons:Press_releases/Picture_of_the_Day_RSS are outdated, and any currently existing RSS feeds would need complicated parsing of unspecified feed content (so prone to change and fail) I found a nice though seemingly proper hack in the code of https://github.com/simison/WikimediaCommonsPotd to first get the filename of the current potd by using the Web API to have the wiki macro "{{Potd}}" be resolved and then get it fetched by Wikimedia Commons' Redirect/file tool. Test Plan: Select wallpaper "Picture of the Day", select as provider "Wikimedia Picture of the Day", click Apply and see a picture fetched, matching the one listed as picture of the day on the wikimedia website like https://commons.wikimedia.org/wiki/Commons:Picture_of_the_day Reviewers: xuetianweng, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11978
-
Friedrich W. H. Kossebau authored
-
- 11 Apr, 2018 8 commits
-
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-
- 10 Apr, 2018 2 commits
-
-
Friedrich W. H. Kossebau authored
-
Friedrich W. H. Kossebau authored
-