Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Add-ons
  • Merge requests
  • !134

Remove unneeded check for comic Dataengine being valid

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexander Lohnau requested to merge work/alex/fix_validity_being_false into Plasma/5.24 Apr 17, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

BUG: 452596

We do not really care, if the metadata of the plugin is valid, as long as we can properly create the dataengine from it.

Test Plan: With plasma-frameworks master, and this on Plasma/5.24 based revision, the dataengine can properly be loaded.

When intenitionally exporting a defunct plugin:

class Dummy : public QObject
{
    Q_OBJECT

public:
    Dummy(QObject *parent, const QVariantList &args) {
    }
};
K_PLUGIN_CLASS_WITH_JSON(Dummy, "plasma-dataengine-comic.json")

The applet does not crash.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/alex/fix_validity_being_false