Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Add-ons
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Add-ons
  • Merge requests
  • !69

Disambiguate identical icons in Large Icons task switcher

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Nate Graham requested to merge ngraham/kdeplasma-addons:use-new-property-in-large-icons-task-switcher into master Apr 25, 2021
  • Overview 15
  • Commits 1
  • Pipelines 0
  • Changes 3

Depends on kwin!897 and kwin!959 (merged).

This commit makes use of the new hasIdenticalIcon property of the TabBox model so that the Large Icons Task Switcher can disambiguate identical icons. It does so by adding window thumbnails to any icons that are identical, which makes the visual representation seen by the user no longer identical.

If compositing is turned off, the new compositingEnabled property of the Switcher item tells us, so we don't try to render the window thumbnail and end up with an overlay of the same icon on top of itself

The icons in the Small Icons Task Switcher are too small for window thumbnails to be distinguishable, so they are not shown for that Task Switcher.

Here's how it looks with two Firefox Windows open:

with_thumbnails

cc @teams/vdg

Edited May 11, 2021 by Nate Graham
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use-new-property-in-large-icons-task-switcher