Commit 62251324 authored by Harald Sitter's avatar Harald Sitter 🏳️‍🌈
Browse files

disable layout twinning in NIC kcm

it blocks the gui for multiple seconds while calculating the layout with
8 addresses. unfortunately because of quirkyness in pretty much all
involved items here I found myself unable to make a properly working
replacement that still looks cool but doesn't block forever and ever.


(cherry picked from commit a4c70c92)
parent 551ff1a8
......@@ -14,7 +14,7 @@ import org.kde.kinfocenter.nic.private 1.0
SimpleKCM {
ConfigModule.quickHelp: i18n("Network Interfaces")
clip: true
Component.onCompleted: {
// The widget thumbnails are a bit more elaborate and need more room, especially when translated
view.implicitCellWidth = Kirigami.Units.gridUnit * 20;
......@@ -29,14 +29,8 @@ SimpleKCM {
Layout.fillHeight: true
contentItem: Kirigami.FormLayout {
id: delegateLayout
twinFormLayouts: {
const size = repeater.count
let items = [];
for (let i = 0; i < size; i++) {
items.push(repeater.itemAt(i).contentItem);
}
return items;
}
// NB: do not make the repeated layouts twinFormLayouts!
// It utterly doesn't scale and causes seconds long lockups while calculating the layout.
Layout.fillWidth: true
QQC2.Label {
Kirigami.FormData.label: i18nc("@label", "Name:")
......@@ -77,7 +71,7 @@ SimpleKCM {
}
}
footer: QQC2.Button {
icon.name: "view-refresh"
text: i18nc("@action:button", "Refresh")
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment