1. 14 Apr, 2020 1 commit
    • Harald Sitter's avatar
      adjust smb kcm size to be sufficient vis a vis headers · f2c5e10d
      Harald Sitter authored
      we use Stretch to get a somewhat uniform appearance between the two views
      but Stretch is bit meh when it comes to actual sizing as it acts kind of
      like QSizePolicy::Preferred in that it allows shrinking columns so small
      that even the header gets cut off. this of course looks silly, so we
      now set the largest required width as minimal section width. this prevents
      the user from cutting off headers by resizing the window.
      secondly, and entirely related to that, because KCMs are embedded into
      a scrollview their sizehint kinda doesn't make any difference for
      the window size which then combined with the aforementioned stretch problem
      can lead to cut off headers by default as the window size is too small
      making the stretch cut into header text.
      to ensure the default size is reasonable let the view adjust to content
      on first show, effectively making the window as large as needed
      regardless of implicit hints.
      BUG: 419786
      FIXED-IN: 5.18.5
      Test Plan:
      - empty dialog
      - dialog with only shares
      - dialog with shares and mounts
      Reviewers: ngraham
      Reviewed By: ngraham
      Subscribers: plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D28678
  2. 08 Feb, 2020 1 commit
    • Harald Sitter's avatar
      replace samba module with data that works · f1768f7b
      Harald Sitter authored
      ... and doesn't require lots of maintenance!
      this targets 5.18 but is kind of unfortunate because it needs a bunch of
      new strings as no existing strings provide what is needed here.
      the previous module was super broken in various ways.
      in the interest of maintainability I've thrown everything out and replaced
      it with 2 core features which require only modeling code on the KInfoCenter
      end and provide actually (possibly) useful functionality to the design
      personas of plasma.
      there is now a single page which contains two table views:
      a) Exports: this is a simple table of shares "exported" from the host. the
         data for this comes from KSambaShare in KIOCore. this is the same API
         used by dolphin to create new shares, so the data will be consistent
         and the API needs maintaining anyway
      b) Imports: simple table of shares "imported" (i.e. mounted) onto the host.
         the data for this comes from solid
      both are backed by models, with an eye towards a future port to qml (out of
      scope since I want this fixed for 5.18)
      all previous functionality was removed, in part because it was doing CLI
      parsing, some of the parsing was broken, some of the CLI tools couldn't
      even run as !root, log parsing could use incorrect paths on existing users,
      log parsing has nothing to parse with samba defaults, log parsing didn't
      implement per-host log file support (current default in samba), log parsing
      didn't correctly implement per-user-config-log-file support.
      in short: there was not a single feature that worked properly.
      BUG: 411433
      BUG: 374141
      BUG: 325951
      FIXED-IN: 5.18.1
      Test Plan:
      # exports
      - nothing when nothing is exported
      - changing exports via dolphin is immediately reflected in the kcm
      - export data is valid
      # imports
      - nothing when nothing is mounted
      - (un)mounting a cifs updates the view immediately
      - data is valid
      Reviewers: #localization, #plasma, #vdg, davidedmundson
      Reviewed By: #plasma, #vdg, davidedmundson
      Subscribers: jriddell, davidedmundson, ltoscano, yurchor, ngraham, alexde, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D27061
  3. 27 Feb, 2019 1 commit
  4. 05 Jul, 2018 1 commit
  5. 22 Oct, 2017 1 commit
  6. 02 Jun, 2017 1 commit
  7. 09 Mar, 2016 1 commit
  8. 08 Mar, 2016 1 commit
  9. 29 Oct, 2015 1 commit
  10. 09 Oct, 2014 1 commit
  11. 07 Oct, 2014 2 commits
  12. 14 May, 2014 1 commit
  13. 15 Oct, 2013 3 commits
  14. 17 Aug, 2011 1 commit
  15. 11 May, 2011 1 commit
  16. 19 Nov, 2010 1 commit
  17. 27 Oct, 2010 1 commit
  18. 24 Apr, 2010 2 commits
  19. 14 Mar, 2010 3 commits
  20. 17 Feb, 2010 1 commit