Follow-up from "allow launching KIC from about-distro"
The following discussion from !78 (merged) should be addressed:
-
@ngraham started a discussion: (+1 comment) Works for me.
The new
ServiceRunner
class feels kind of heavy though. Do we really not have a generic way to get an app's icon and name from QML? If not, it seems like we should implement that elsewhere and then use it here.Alternatively, we could avoid having to create that new class by simply hardcoding Info Center's executable name and icon in the code here. That's the simple, crappy, lazy approach that I personally would take, just because it results in less code, and less code generally means fewer bugs.
Not a blocker to merging, just some ramblings.