Commit e0268dc8 authored by Harald Sitter's avatar Harald Sitter 🦄

improve some previously recycled strings

Summary:
for 5.18 we recycled these to reduce the new strings, for 5.19 we want
something more approachable

Test Plan: fancy new strings show up

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27325
parent 0ebbd9b4
......@@ -49,9 +49,9 @@ SambaContainer::SambaContainer(QWidget *parent, const QVariantList &)
Q_ASSERT(this->layout());
setLayout(layout);
addTableView(i18n("&Exports"), new KSambaShareModel(this));
addTableView(i18nc("@title/group", "Exported Shares"), new KSambaShareModel(this));
auto importsView = addTableView(i18n("&Imports"), new SmbMountModel(this));
auto importsView = addTableView(i18nc("@title/group", "Mounted Shares"), new SmbMountModel(this));
importsView->horizontalHeader()->setSectionResizeMode(static_cast<int>(SmbMountModel::ColumnRole::Accessible),
QHeaderView::ResizeToContents);
......@@ -60,11 +60,8 @@ SambaContainer::SambaContainer(QWidget *parent, const QVariantList &)
QTableView *SambaContainer::addTableView(const QString &localizedLabel, QAbstractListModel *model)
{
QString text = localizedLabel;
auto title = new KTitleWidget(this);
// hackily remove ampersand to not break i18n too much in 5.18
// TODO: replace i18n'd string to one without quick access marker
title->setText(text.remove("&"));
title->setText(localizedLabel);
title->setLevel(2);
layout()->addWidget(title);
......
......@@ -46,9 +46,9 @@ QVariant SmbMountModel::headerData(int section, Qt::Orientation orientation, int
Q_ASSERT(section <static_cast<int>(ColumnRole::ColumnCount));
switch (static_cast<ColumnRole>(section)) {
case ColumnRole::Share:
return i18n("Resource"); // TODO: maybe reword for 5.19
return i18n("Resource");
case ColumnRole::Path:
return i18n("Mounted Under"); // TODO: maybe reword for 5.19
return i18n("Mounted Under");
case ColumnRole::Accessible:
return i18nc("@title:column whether a samba share is accessible locally (i.e. mounted)", "Accessible");
case ColumnRole::ColumnCount:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment