Commit 8997b007 authored by Nate Graham's avatar Nate Graham
Browse files

Rephrase "Only show in KDE" for accuracy and clarity

KDE is no longer the name of a desktop environment; let's rephrase this
to use the actual name of the DE and also be a bit clearer about what
the setting actually does.

BUG: 433646
FIXED-IN: 5.22
parent 01a673a2
......@@ -95,7 +95,7 @@ void BasicTab::initGeneralTab()
generalTabLayout->addWidget(_launchCB, 4, 0, 1, 3);
// KDE visibility
_onlyShowInKdeCB = new QCheckBox(i18n("Only show in KDE"));
_onlyShowInKdeCB = new QCheckBox(i18n("Only show when logged into a Plasma session"));
generalTabLayout->addWidget(_onlyShowInKdeCB, 5, 0, 1, 3);
// hidden entry
......@@ -397,7 +397,7 @@ void BasicTab::apply()
QStringList onlyShowIn = df->desktopGroup().readXdgListEntry("OnlyShowIn");
/* the exact semantics of this checkbox are unclear if there is more than just KDE in the list...
* For example: - The list is "Gnome;", the user enables "Only show in KDE" - should we remove Gnome?
* For example: - The list is "Gnome;", the user enables "Only show when logged into a Plasma session" - should we remove Gnome?
* - The list is "Gnome;KDE;", the user unchecks the box - should we keep Gnome?
if (_onlyShowInKdeCB->isChecked() && !onlyShowIn.contains(QLatin1String("KDE"))) {
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment