Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14361

Summary: Making the other timers lazy-initialized is more tricky, so for now just touch the saveTimer.

Reviewers: #plasma, romangg

Reviewed By: #plasma, romangg

Subscribers: romangg, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14359

Summary:
When there is only one widget inside the layout, it would have double
margins. In case of the slider, the top and bottom margins are slightly
off (same as before), but at least on the left and right they now fit.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: andreaska, abetts, ngraham, broulik, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14326

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14403

Summary:
Right now there is an icon associated with each rotation, but they
do not actually make much sense since they are not rotation arrows, but just
arrows pointing to the sides/up/down.
Instead use the view-preview icon and rotate it.

Reviewers: #plasma, #vdg, ngraham, romangg

Reviewed By: #plasma, #vdg, ngraham, romangg

Subscribers: abetts, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14339

Summary:
There is nothing current about currentConfig, this is generic.
Make it consistent with the declaration.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14358

Summary:
It worked when I wrote it against integer scaling, it got broken when
fractional support was added, resulting in it rendering at the wrong
size when the host scaling is non integer.

BUG: 388218

Test Plan:
Ran with QT_SCALE_FACTOR=1.5 to simulate the host being at that scale
Opened preview and moved slider
At 1.0 buttons were smaller than the main KCM
At 1.5 buttons looked the same
At 2.0 looked bigger

Reviewers: broulik

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14338

Summary:
There was only one option hidden behind the andvanced section, just have
one line for refresh rate that is visible.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, andreaska, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14325

Summary:
The OSD is not all that bad, but it was only usable with the mouse.
Change it so that left-right and tab navigates and space/return confirms
the selection.

BUG: 395804

Reviewers: #plasma, davidedmundson

Subscribers: broulik, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14165

Summary:
This OSD should handle keyboard input and behave different, so make it work on its own.
In follow up changes, the keyboard handling will be added.

CCBUG: 395804

Reviewers: #plasma, davidedmundson

Subscribers: broulik, davidedmundson, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14143

Summary: The function does exactly the same as these two lines.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14225

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14228

Summary:
When we determine to show a refresh rate, it should rather be the
correct one. This was off by one.

Test Plan: Checked with my laptop display which used to wrongly display 47.99 Hz instead of 59.98

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14328

Summary: This has no practical implications, but generates a warning (from uic) when compiling.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14223

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14213

Summary:
The OsdManager was trying to be a singleton while used from only one
place. Simplify it.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14166

Summary:
Let's leave it up to the compiler to eliminate the ref.
Suggested by zzag.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14152

Summary: In this case we would allocate to create a QString instance since there is no Latin1 overload.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14076

There is no point in creating the lambda, simplify.
As suggested by	Kai Uwe Broulik.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14075

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14074

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14073

Summary:
Use QT_NO_CAST_FROM_ASCII and friends. There are a bunch of places where
QString should really be QByteArray, but that's for the future.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14065

This fixes the size policy, the only element we want expanding is the
preview area on top, everything else should be layouted with preferred
size.

Differential Revision: https://phabricator.kde.org/D14024

Summary:
This will make it easier to re-design the UI.
Also it centralizes all updates, before a bunch of connections for the
individual outputs were not made when a new output appeared.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14023

Summary:
For consistency with other Plasma repos, but also to ensure the ECM
logic for supporting uninstalled unit tests is properly triggered
See
https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings

Including KDECMakeSettings only after finding KF5CoreAddons and the
implicit loading of KF5PlasmaMacros/KF5PackageMacros resets the
ECM_GLOBAL_FIND_VERSION variable to the min ECM value 1.6.0 currently
used by those macro files, thus below the trigger value 5.38

Test Plan: Still builds and installs as before.

Reviewers: gladhorn, sebas, romangg, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14031

Fix clazy warning. at() is the right choice here in any case.

GIT_SILENT

At least when iterating over pointers.