GitLab

Fixed screen rotation UI so that the arrows in drop down menus point in
the appropriate directions and the screen preview matches the direction
in which the screen rotates on applying the changes.

Patch from Akshay Naik <nike.falcon@gmail.com>, thanks!

REVIEW:130038

Summary:
When identical displays are connected, the identify overlay would display
the output name, while the preview in the kcm displays the display vendor
and model. There's no way to tell which display is which.

This patch adds a row in the output preview, it moves the vendor up,displays and displays the output name underneath (if not duplicated).

BUG:362570

Before: {F190822}

After: {F190823}

Test Plan:
started kcm with multiple displays connected, I can now distinguish them
based on the name of the connector

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2248

When using threaded rendering loop [1] systemsettings crashed when
clicking the back button. This crash is caused inside the shader effect
used by the OpacityMask.
QtQuick informed us also that something is wrong:
"QSGDefaultLayer::bind: ShaderEffectSource: 'recursive' must be set to true when rendering recursively."

The actual problem is that orientationPanelContainer and the OpacityMask
are children to the monitor item causing recursion. By making them
siblings to the orientationPanelContainer the problem is resolved. The
error message from QtQuick is no longer shown and systemsettings doesn't
crash any more.

BUG: 344651
FIXED-IN: 5.4.3
REVIEW: 125734

[1] QSG_RENDER_LOOP=threaded systemsettings5

Update current item in rotation combobox in OutputConfig, and call
QMLOutput.updateRootProperties() once the Output.qml is consructed,
so that the output root is correctly resized and repositioned.

If the QMLOutput represents a monitor, then rotation by 90° clockwise means
we actually want to rotate the visual rectangle by 90 degrees clockwise, not
the other way around.

The KCM now visually correctly represents how you would have to rotate your
monitor in order to see content of the screen right.

BUG: 335211
FIXED-IN: 5.2.1

CCMAIL:david@davidedmundson.co.uk

CCMAIL:david@davidedmundson.co.uk

It is quite verbose as it was using some intrinsic API of QGraphicsView that
is obviously not available anymore.
It seems to work to some extent now, but it would be really good if there
was some testing since I'm unsure about how to test it.

CCMAIL: Dan Vrátil <dan.vratil@gmail.com>

Instead of displaying all outputs and making the collapsable,
we only display configuration of output currently selected in
the view.

BUG: 315062
FIXED-IN: 1.0

 - disable the enable/disable switch when only one monitor is available
 - show a warning when no screens are active
 - change button labels in the confirmation dialog

CCBUG: 314424

Update virtual positions of all outputs when an output is
disabled. This prevents situation when left output has been
disabled in KCM, but the X position of the right display was
not updated to 0.

BUG: 313027

 - currentMode -> currentModeId
 - currentMode() now returns Mode*
 - same for preferredMode
 - use isHorizontal()

Thanks to Stefan Hepp for pointing out the broken code.

BUG: 314098
BUG: 314418
FIXED-IN: 0.0.72

not entirely happy with this, as the "on" switch also dims

however.. testers were unable to connect the shrinking of the monitor
with it being "off", even with the UI components being hidden. worse,
if there is another screen with the same resolution, then one has
two rectangles of the same size but one is lacking controls -> confusing.

until moving, this information is a distraction. when asked, test
subjects were unable to describe what it refered to until moving
occurred.

Use Qt::OpenHandCursor when hovering anywhere on output
(except for buttons - fallback to Qt::ArrowCursor there)
and Qt::ClosedHandCursor when dragging the output around.

This is mostly a hack, because there is no way to change
cursor directly from QML, so we are through signals
changing cursor of the QDeclarativeView from C++ code.

BUG: 313958

- fixes initial placement of disabled outputs because of iternal KCM
  window resize
- fixes layout being messed up when KCM window is resized manually

BUG: 313975
BUG: 313956

This prevents Output's outlines being invisible when the
output is scaled down.

CCBUG: 313956

Counter clockwise rotation should be normal, left, inverted, right
and vice versa.
REVIEW: 108415

Outputs automatically become draggable when a second output
is connected.

CCBUG: 313090