Summary:
Let's leave it up to the compiler to eliminate the ref.
Suggested by zzag.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14152

Summary: In this case we would allocate to create a QString instance since there is no Latin1 overload.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14076

There is no point in creating the lambda, simplify.
As suggested by	Kai Uwe Broulik.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14075

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14074

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14073

Summary:
Use QT_NO_CAST_FROM_ASCII and friends. There are a bunch of places where
QString should really be QByteArray, but that's for the future.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14065

This fixes the size policy, the only element we want expanding is the
preview area on top, everything else should be layouted with preferred
size.

Differential Revision: https://phabricator.kde.org/D14024

Summary:
This will make it easier to re-design the UI.
Also it centralizes all updates, before a bunch of connections for the
individual outputs were not made when a new output appeared.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14023

Summary:
For consistency with other Plasma repos, but also to ensure the ECM
logic for supporting uninstalled unit tests is properly triggered
See
https://api.kde.org/ecm/kde-module/KDECMakeSettings.html#build-settings

Including KDECMakeSettings only after finding KF5CoreAddons and the
implicit loading of KF5PlasmaMacros/KF5PackageMacros resets the
ECM_GLOBAL_FIND_VERSION variable to the min ECM value 1.6.0 currently
used by those macro files, thus below the trigger value 5.38

Test Plan: Still builds and installs as before.

Reviewers: gladhorn, sebas, romangg, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14031

Fix clazy warning. at() is the right choice here in any case.

At least when iterating over pointers.

As needed for running tests installed with min. ECM 5.38

align with rest of Plasma

I have two screens where for some reason the vendor is empty in the EDID
information. At least return the model name.

That entry has never been used, instead the plugin id (as by
KPluginMetaData::pluginId()) has been used for the module name in the
D-Bus object path, here currently derived from the plugin binary name
(kscreen).

GIT_SILENT

GIT_SILENT

GIT_SILENT

GIT_SILENT