1. 16 Oct, 2019 1 commit
  2. 10 Oct, 2019 1 commit
  3. 30 Sep, 2019 1 commit
  4. 27 Sep, 2019 1 commit
  5. 23 Sep, 2019 1 commit
  6. 19 Sep, 2019 5 commits
    • Luigi Toscano's avatar
      Revert "Revert "i18n fixes"" · a81d5e0d
      Luigi Toscano authored
      Summary:
      As translator, any supposed arbitrary coding style which
      breaks the translation is not acceptable.
      We can certainly discuss the proper long term solution
      about fixing the coding style, about fixing QML, about
      fixing gettext, or any other fix, but knowingly
      breaking the translations is not acceptable.
      
      We can certainly discuss after.
      
      This reverts commit b5fc1a76.
      
      Test Plan: Transltions works.
      
      Reviewers: #plasma, romangg
      
      Reviewed By: #plasma, romangg
      
      Subscribers: bshah, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24073
      a81d5e0d
    • Roman Gilg's avatar
      Revert "i18n fixes" · b5fc1a76
      Roman Gilg authored
      This reverts commit 6ae066c0.
      
      The change breaks the 100 chars limit on source code set as part of the
      Frameworks Coding Style.
      
      If there is currently no other possibility to facilitate translations of long
      text lines in QML without breaking this limit a temporary exception can be
      made, but this needs to be discussed first and a plan must be drafted on how to
      solve this conflict in the future.
      
      To start such a discussion about short and long-term solution please create a
      review on Phabricator for this change.
      
      CCMAIL: pino@kde.org
      b5fc1a76
    • Jonathan Esk-Riddell's avatar
      Update version number for 5.16.90 · 33df4790
      Jonathan Esk-Riddell authored
      GIT_SILENT
      33df4790
    • Jonathan Esk-Riddell's avatar
      update to latest kf5 dependency · c933f32c
      Jonathan Esk-Riddell authored
      c933f32c
    • Pino Toscano's avatar
      i18n fixes · 6ae066c0
      Pino Toscano authored
      - avoid string concatenation in i18n literals, as they are not valid
        strings to extract
      - style fixes
      6ae066c0
  7. 18 Sep, 2019 2 commits
  8. 17 Sep, 2019 2 commits
    • Roman Gilg's avatar
      Delay load on output add/remove · 7efeabc5
      Roman Gilg authored
      Summary:
      In order to give the KScreen daemon time to update the config settings after
      an output has been removed or added delay the load call by one second.
      
      Test Plan: Tested on Wayland and X.
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24021
      7efeabc5
    • Nate Graham's avatar
      Polish Displays KCM UI · d0dc9a7a
      Nate Graham authored
      Summary:
      This patch improves and polishes the new KScreen KCM's UI in a variety of ways. A picture
      says a thousand words, so look at the pictures. :)
      
      BUG: 348126
      FIXED-IN: 5.17.0
      
      Test Plan:
      Due to an unrelated bug, my second screen isn't showing up in the visualization, so please excuse the fact that only one appears there in these screenshots:
      
      {F7369458}
      
      {F7369494}
      
      All functionality that was working before is still working now.
      
      Reviewers: romangg, #vdg, #kwin, GB_2
      
      Reviewed By: romangg, #vdg, #kwin, GB_2
      
      Subscribers: filipf, ndavis, GB_2, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23798
      d0dc9a7a
  9. 10 Sep, 2019 2 commits
  10. 08 Sep, 2019 5 commits
  11. 06 Sep, 2019 1 commit
  12. 05 Sep, 2019 4 commits
    • Roman Gilg's avatar
      [kded] Save replication source hash to config file · 1ee9b20b
      Roman Gilg authored
      Summary:
      When a replication source is set write its output hash to the config file and
      load the value again on next startup. If no replication source is set the
      value written is an empty string.
      
      Test Plan: Tested on X11.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23733
      1ee9b20b
    • Roman Gilg's avatar
      [kcm] Provide graphical interface to replicate outputs · 6e7fd472
      Roman Gilg authored
      Summary:
      This adds visual means to describe and manipulate the set of replicas of an
      output.
      
      Heuristics are included for proper repositioning of outputs. An alternative
      approach would be to save former values, but for now this seems to work fine
      in most cases.
      
      At the moment the replication status is not yet saved via the KScreen daemon
      to the configuration file what needs another presumably small patch to KScreen.
      
      **Video:** https://www.youtube.com/watch?v=j__FJZK-A-0
      
      {F7308512}
      {F7308515}
      
      Test Plan: Tested on X11 and Wayland with patches to libkscreen, KWayland and KWin.
      
      Reviewers: #kwin, #plasma
      
      Maniphest Tasks: T11222
      
      Differential Revision: https://phabricator.kde.org/D23666
      6e7fd472
    • Roman Gilg's avatar
      Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami · 6309d33f
      Roman Gilg authored
      Summary:
      The KScreen KCM was still partly Qt Widgets based. Also it did not use a
      model for the outputs but instead created objects in C++ for visual
      representation of the outputs.
      
      This patch bases the KScreen KCM on ConfigModule removing any dependency
      on Qt Widgets. The former widgets based settings form is rewritten as
      Kirigami form layout.
      
      The already existing QML part has been also rewritten with a model as
      data provider for the outputs and input handlers for interacting with the
      outputs in the overview.
      
      On hotplug events the settings dialog is reset and the user is informed.
      
      Output retention now is set for the whole config instead of individual
      outputs what simplifies it.
      
      On Wayland output scaling is now fractional via a slider. This has not yet
      been tested though and there might be some more work necessary in KWin.
      
      The output unification has been removed for now. It was broken in certain
      ways and we should try instead to improve the libkscreen backend to make
      unficiation more easy to use. For now as a workaround the outputs can be
      placed on top of each other to create a clone effect.
      
      The KScreen maintainership is changed to me.
      
      X11:
      {F7024716}
      
      Wayland:
      {F7024721}
      
      Test Plan: Manually on X and Wayland.
      
      Reviewers: #plasma, #kwin, #vdg, ngraham
      
      Reviewed By: #vdg
      
      Subscribers: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel
      
      Tags: #plasma, #vdg
      
      Maniphest Tasks: T11217, T10273
      
      Differential Revision: https://phabricator.kde.org/D22468
      6309d33f
    • Roman Gilg's avatar
      [kded] Support fractional output scale · 305078f0
      Roman Gilg authored
      Summary:
      Read and write fractional output scale values to conifg. We currently round to
      one digit.
      
      Reviewers: #plasma
      
      Subscribers: broulik, cfeck, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23732
      305078f0
  13. 08 Aug, 2019 1 commit
  14. 02 Aug, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Improved OSD behavior · 43a62043
      Kai Uwe Broulik authored
      Don't ask the user for a screen configuration on login, instead, apply a sane default.
      When connecting a new screen, apply a default configuration so the user gets immediate
      feedback "something's happening" and then prompt for a configuration via the OSD in case
      the chosen default doesn't fit.
      
      BUG: 398816
      FIXED-IN: 5.17.0
      
      Differential Revision: https://phabricator.kde.org/D22803
      43a62043
  15. 04 Jul, 2019 2 commits
  16. 21 Jun, 2019 1 commit
  17. 13 Jun, 2019 9 commits
    • Roman Gilg's avatar
      On config read adjust outputs positions to global value changes · 2f26bf7f
      Roman Gilg authored
      Summary:
      Some global output values directly influence the positions of outputs relative
      to each other, at the moment namely scale and rotation.
      
      In order to guarantee a working setup after such a global output property was
      changed and a config is loaded, which had been created with outdated values,
      adjust positions programmatically such that the relative distances between
      outputs are preserved.
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D21110
      2f26bf7f
    • Roman Gilg's avatar
      [kcm] Expose interface to control output property retention · 62837af0
      Roman Gilg authored
      Summary:
      This adds two radio buttons to the kcm, that allow to change the output
      property retention of the output currently being modified.
      
      The default value is global property retention.
      
      {F6431307}
      
      Closes T10028
      
      Test Plan: Autotest passes.
      
      Reviewers: #plasma
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16997
      62837af0
    • Roman Gilg's avatar
      Add method to write retention to configuration control files · 06b90b31
      Roman Gilg authored
      Summary:
      This patch adds a small method to ControlConfig which writes modified
      retention values to the control file of the configuration.
      
      Test Plan: Compiles.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16996
      06b90b31
    • Roman Gilg's avatar
      Consider identical display models in ControlConfig · 153e6e5f
      Roman Gilg authored
      Summary:
      Load the correct control information in configurations with identical
      displays having the same EDID data by checking additionally the names
      of the displays, which are supposed to contain information about the
      connectors being used.
      
      Test Plan: Compiles. Auto test passes.
      
      Reviewers: #plasma
      
      Subscribers: mart, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16995
      153e6e5f
    • Roman Gilg's avatar
      Split Control class into configurations and outputs control classes · 18bc53a3
      Roman Gilg authored
      Summary:
      In order to control the behavior of global output data and configuration
      data in a structured manner split the Control class up into subclasses
      for control of global data of outputs and data of configurations.
      
      Test Plan: Autotest passes.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16994
      18bc53a3
    • Roman Gilg's avatar
      Add a common directory for functionality being used by kcm and daemon · ba9681bf
      Roman Gilg authored
      Summary:
      Certain functionality will be shared between kcm and daemon in the future,
      but is for now not extensive  enough to be put into libkscreen.
      
      In order to still reduce code duplication add a common top-level directory.
      
      Initially this directory contains the data root path logic and the Control
      classed, such that the kcm can access it in the future as well.
      
      Test Plan: Autotest passes.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16993
      ba9681bf
    • Roman Gilg's avatar
      Introduce secondary control channel of the KScreen daemon · 466c278f
      Roman Gilg authored
      Summary:
      Kcm and daemon can only communicate a limited data set through the backend.
      This feature patch adds an additional level of control by providing a one-way
      control channel through output and configuration control files.
      
      The first property to be controlled through this channel is the output
      retention. Other information shared in the future might be if a certain
      resolution or refresh rate was manually set by the user or is the result
      of an algorithm, so that the daemon on next startup can decide to recompute
      the optimal value.
      
      Test Plan:
      Autotests updated, such that they are controled for now to only use
      indvidual retention.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16992
      466c278f
    • Roman Gilg's avatar
      Introduce concept of global and individual output data retention · 979e43f9
      Roman Gilg authored
      Summary:
      This is a new concept allowing the user to specifiy properties of a display
      model (in best case identified by its EDID) on a global level.
      
      This means independent of the setup/configuration of displays the display
      model is part of its global properties are preserved.
      
      The properties are for now:
      * resolution,
      * scale factor,
      * rotation,
      * refresh rate.
      
      While redefining global values is possible at any time, user is also able to
      specify for individual configurations special settings deviating from the
      global values.
      
      Test Plan: Manually. Autotest broken due to altered behavior.
      
      Reviewers: #plasma, mart
      
      Reviewed By: #plasma, mart
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16991
      979e43f9
    • Roman Gilg's avatar
      [kded] Separate configuration storage path · a17ccc22
      Roman Gilg authored
      Summary:
      As a preparatory step save the configuration storage directory in a separate
      subfolder variable. In KDE6 this should go into a separate subfolder 'config'
      of the current data directory.
      
      Test Plan: Autotest updated.
      
      Reviewers: #plasma
      
      Subscribers: davidedmundson, broulik, plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T10028
      
      Differential Revision: https://phabricator.kde.org/D16990
      a17ccc22