1. 11 Nov, 2019 1 commit
    • Roman Gilg's avatar
      feat(kcm): always use 0.25 slider scale steps · fb170c3a
      Roman Gilg authored
      Summary:
      The number of sllider ticks is reduced, making the slider more easy to control.
      Fine-grained control is still possible via the spin box.
      
      This way we have the same behavior on X11 and Wayland.
      
      Test Plan: Manually
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Maniphest Tasks: T11928
      
      Differential Revision: https://phabricator.kde.org/D25026
      fb170c3a
  2. 17 Oct, 2019 1 commit
  3. 16 Oct, 2019 1 commit
    • Nate Graham's avatar
      [KCM] Display scale factor as a percentage, not a decimal · 0f52663c
      Nate Graham authored
      Summary:
      This is the way GNOME and Windows present this information, and I think it's clearer
      than using a decimal value.
      
      The underlying value is still a float, we just convert to an int in percentage form for
      display purposes.
      
      Test Plan: {F7500851}
      
      Reviewers: #vdg, #plasma, romangg, ndavis
      
      Reviewed By: #vdg, #plasma, romangg, ndavis
      
      Subscribers: ndavis, dhaumann, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24370
      0f52663c
  4. 02 Oct, 2019 1 commit
    • Nate Graham's avatar
      [KCM] Scale more coarsely with the slider, but more finely with a spinbox · 7a9387ed
      Nate Graham authored
      Summary:
      Right now we have a problem in that the important scale factors of 1.25 and 1.75 are
      not reachable using the UI. However just reducing the slider increment to 0.05 would
      result in way too many slider values. Instead, this patch implements the following:
      - The slider goes by increments of 0.25
      - There's a spinbox beside the slider that allows the user to set the scale factor by 0.05 increments
      - On X11 with global scaling, the user is shown a warning message when using scale factors that are not a multiple of 0.25
      
      This way the commonly-used scale factors are more accessible, but finer values are
      made available to people who really need them and are likely to go poking around.
      
      BUG: 412447
      FIXED-IN: 5.18.0
      
      Test Plan: {F7489713}
      
      Reviewers: #vdg, #plasma, romangg, ndavis
      
      Reviewed By: #vdg, #plasma, romangg, ndavis
      
      Subscribers: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D24321
      7a9387ed
  5. 17 Sep, 2019 1 commit
    • Nate Graham's avatar
      Polish Displays KCM UI · d0dc9a7a
      Nate Graham authored
      Summary:
      This patch improves and polishes the new KScreen KCM's UI in a variety of ways. A picture
      says a thousand words, so look at the pictures. :)
      
      BUG: 348126
      FIXED-IN: 5.17.0
      
      Test Plan:
      Due to an unrelated bug, my second screen isn't showing up in the visualization, so please excuse the fact that only one appears there in these screenshots:
      
      {F7369458}
      
      {F7369494}
      
      All functionality that was working before is still working now.
      
      Reviewers: romangg, #vdg, #kwin, GB_2
      
      Reviewed By: romangg, #vdg, #kwin, GB_2
      
      Subscribers: filipf, ndavis, GB_2, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D23798
      d0dc9a7a
  6. 05 Sep, 2019 2 commits
    • Roman Gilg's avatar
      [kcm] Provide graphical interface to replicate outputs · 6e7fd472
      Roman Gilg authored
      Summary:
      This adds visual means to describe and manipulate the set of replicas of an
      output.
      
      Heuristics are included for proper repositioning of outputs. An alternative
      approach would be to save former values, but for now this seems to work fine
      in most cases.
      
      At the moment the replication status is not yet saved via the KScreen daemon
      to the configuration file what needs another presumably small patch to KScreen.
      
      **Video:** https://www.youtube.com/watch?v=j__FJZK-A-0
      
      {F7308512}
      {F7308515}
      
      Test Plan: Tested on X11 and Wayland with patches to libkscreen, KWayland and KWin.
      
      Reviewers: #kwin, #plasma
      
      Maniphest Tasks: T11222
      
      Differential Revision: https://phabricator.kde.org/D23666
      6e7fd472
    • Roman Gilg's avatar
      Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami · 6309d33f
      Roman Gilg authored
      Summary:
      The KScreen KCM was still partly Qt Widgets based. Also it did not use a
      model for the outputs but instead created objects in C++ for visual
      representation of the outputs.
      
      This patch bases the KScreen KCM on ConfigModule removing any dependency
      on Qt Widgets. The former widgets based settings form is rewritten as
      Kirigami form layout.
      
      The already existing QML part has been also rewritten with a model as
      data provider for the outputs and input handlers for interacting with the
      outputs in the overview.
      
      On hotplug events the settings dialog is reset and the user is informed.
      
      Output retention now is set for the whole config instead of individual
      outputs what simplifies it.
      
      On Wayland output scaling is now fractional via a slider. This has not yet
      been tested though and there might be some more work necessary in KWin.
      
      The output unification has been removed for now. It was broken in certain
      ways and we should try instead to improve the libkscreen backend to make
      unficiation more easy to use. For now as a workaround the outputs can be
      placed on top of each other to create a clone effect.
      
      The KScreen maintainership is changed to me.
      
      X11:
      {F7024716}
      
      Wayland:
      {F7024721}
      
      Test Plan: Manually on X and Wayland.
      
      Reviewers: #plasma, #kwin, #vdg, ngraham
      
      Reviewed By: #vdg
      
      Subscribers: #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel
      
      Tags: #plasma, #vdg
      
      Maniphest Tasks: T11217, T10273
      
      Differential Revision: https://phabricator.kde.org/D22468
      6309d33f