KScreen merge requestshttps://invent.kde.org/plasma/kscreen/-/merge_requests2024-03-16T03:09:41Zhttps://invent.kde.org/plasma/kscreen/-/merge_requests/293OsdAction: fix applying mode on X112024-03-16T03:09:41ZFushan WenOsdAction: fix applying mode on X11The output list contains disconnected ports, but the count should be
based on connected ports.
BUG: 482642
FIXED-IN: 6.0.3The output list contains disconnected ports, but the count should be
based on connected ports.
BUG: 482642
FIXED-IN: 6.0.36https://invent.kde.org/plasma/kscreen/-/merge_requests/292KCM: Make sure HDR UI elements aren't shown when HDR isn't available2024-03-08T00:56:37ZNate GrahamKCM: Make sure HDR UI elements aren't shown when HDR isn't availableRight now we're assuming that HDR can only be enabled when available,
but that's actually not the case, as HDR can become unavailable later
after having previously enabled it. This can cause the KCM to display
inappropriate UI elements.
...Right now we're assuming that HDR can only be enabled when available,
but that's actually not the case, as HDR can become unavailable later
after having previously enabled it. This can cause the KCM to display
inappropriate UI elements.
Fix that by also adding an "Is HDR available?" check to the visibility
conditions that currently only check whether HDR is currently enabled.
BUG: 482748
FIXED-IN: 6.0.2
(cherry picked from commit ef143b4096fd07716de89bd61370cba7f1fc23fd)
bdb731c1 KCM: Make sure HDR UI elements aren't shown when HDR isn't available
b8892082 Apply 2 suggestion(s) to 1 file(s)6https://invent.kde.org/plasma/kscreen/-/merge_requests/291KCM: Make sure HDR UI elements aren't shown when HDR isn't available2024-03-08T00:54:55ZNate GrahamKCM: Make sure HDR UI elements aren't shown when HDR isn't availableRight now we're assuming that HDR can only be enabled when available,
but that's actually not the case, as HDR can become unavailable later
after having previously enabled it. This can cause the KCM to display
inappropriate UI elements.
...Right now we're assuming that HDR can only be enabled when available,
but that's actually not the case, as HDR can become unavailable later
after having previously enabled it. This can cause the KCM to display
inappropriate UI elements.
Fix that by also adding an "Is HDR available?" check to the visibility
conditions that currently only check whether HDR is currently enabled.
BUG: 482748
FIXED-IN: 6.0.2
Note: I don't have an HDR-compatible system so I was only able to test this by overriding the new bool property to always be true. It would be nice to get a test from someone with compatible hardware.6https://invent.kde.org/plasma/kscreen/-/merge_requests/290Properly restore "Device" combobox when the output model resets2024-02-26T18:14:30ZJakob PetsovitsProperly restore "Device" combobox when the output model resetsScreenSortProxyModel::setSourceModel(nullptr) will cause the
ComboBox to set the currentIndex property to -1, which also kills
its binding. We restore the binding and ensure that we're setting
an output to a valid index within the newly ...ScreenSortProxyModel::setSourceModel(nullptr) will cause the
ComboBox to set the currentIndex property to -1, which also kills
its binding. We restore the binding and ensure that we're setting
an output to a valid index within the newly reset model.
(cherry picked from commit cbdbfd43dce5ca27c47d07c767e4efd0fcdf23c5)6https://invent.kde.org/plasma/kscreen/-/merge_requests/288Properly restore "Device" combobox when the output model resets2024-02-26T17:49:41ZJakob PetsovitsProperly restore "Device" combobox when the output model resetsScreenSortProxyModel::setSourceModel(nullptr) will cause the
ComboBox to set the currentIndex property to -1, which also kills
its binding. We restore the binding and ensure that we're setting
an output to a valid index within the newly ...ScreenSortProxyModel::setSourceModel(nullptr) will cause the
ComboBox to set the currentIndex property to -1, which also kills
its binding. We restore the binding and ensure that we're setting
an output to a valid index within the newly reset model.
---
To reproduce:
1. Ensure that two or more displays are connected
2. Drag one of the screens to a different position relative to the other screen(s)
3. Press "Reset" button
Expected behavior:
* "Device" combobox displays the currently selected screen
Observed behavior:
* "Device" combobox is now empty, a screen must be selected either via combobox or by clicking one of the display representations in the screen positioning canvas in order for the combobox to have a proper selection again.
Didn't find any corresponding bug in Bugzilla, at least for the `kscreen` component.6https://invent.kde.org/plasma/kscreen/-/merge_requests/286Changed template literal strings to normal ones so they are translatable2024-02-23T15:54:28ZJure Repincjlp@holodeck1.comChanged template literal strings to normal ones so they are translatable6Jure Repincjlp@holodeck1.comJure Repincjlp@holodeck1.comhttps://invent.kde.org/plasma/kscreen/-/merge_requests/283kcm: port remaining kcm.outputModel.rowCount()2024-02-08T19:40:28ZYifan Zhukcm: port remaining kcm.outputModel.rowCount()Port the remaining kcm.outputModel.rowCount() > 1 to
kcm.multipleScreensAvailable left out in
5cf9c326baabfd8b55cee7fa09ef3c0a9b488f42.
BUG: 481072
FIXED-IN: 6.0
This should be the last one left (verified by grepping)Port the remaining kcm.outputModel.rowCount() > 1 to
kcm.multipleScreensAvailable left out in
5cf9c326baabfd8b55cee7fa09ef3c0a9b488f42.
BUG: 481072
FIXED-IN: 6.0
This should be the last one left (verified by grepping)6Yifan ZhuYifan Zhuhttps://invent.kde.org/plasma/kscreen/-/merge_requests/281common/osdaction: correct extend left/right being swapped around2024-02-07T22:42:47ZXaver Huglcommon/osdaction: correct extend left/right being swapped aroundBUG: 480993
FIXED-IN: 6.0
(cherry picked from commit d152e1c9dc11626960159c56d647c7a144f42297)BUG: 480993
FIXED-IN: 6.0
(cherry picked from commit d152e1c9dc11626960159c56d647c7a144f42297)6https://invent.kde.org/plasma/kscreen/-/merge_requests/280common/osdaction: correct extend left/right being swapped around2024-02-07T22:41:11ZXaver Huglcommon/osdaction: correct extend left/right being swapped aroundBUG: 480993
FIXED-IN: 6.0BUG: 480993
FIXED-IN: 6.06https://invent.kde.org/plasma/kscreen/-/merge_requests/278Sort enabled outputs first2024-02-08T05:34:10ZDavid EdmundsonSort enabled outputs firstWe want the combobox and stackview to show the most relevant outputs
first.
As indexes are passed between here and the top view we move sorting
lower in the stack.
This also saves QML from having to deal with the model object changing....We want the combobox and stackview to show the most relevant outputs
first.
As indexes are passed between here and the top view we move sorting
lower in the stack.
This also saves QML from having to deal with the model object changing.
From a QML POV it'll now be the same object resetting.
> visible: kcm.outputModel.rowCount() > 1
Is ported as this is unsafe. We're calling an invokable as a property so
it won't update. A new explicit property is introduced on the KCM.6https://invent.kde.org/plasma/kscreen/-/merge_requests/277cherry-pick kcm: hide auto rotation stuff when not useful2024-02-03T22:07:48ZXaver Huglcherry-pick kcm: hide auto rotation stuff when not usefulCherry pick of https://invent.kde.org/plasma/kscreen/-/merge_requests/276Cherry pick of https://invent.kde.org/plasma/kscreen/-/merge_requests/2766https://invent.kde.org/plasma/kscreen/-/merge_requests/276kcm: hide auto rotation stuff when not useful2024-02-03T22:06:45ZXaver Huglkcm: hide auto rotation stuff when not usefulCommit 1: hide "only in tablet mode" checkbox when tablet mode isn't available
Commit 2: fix `OrientationSensor::available`
Someone with a (working) auto rotation sensor should test this to ensure it still works correctly in that caseCommit 1: hide "only in tablet mode" checkbox when tablet mode isn't available
Commit 2: fix `OrientationSensor::available`
Someone with a (working) auto rotation sensor should test this to ensure it still works correctly in that case6https://invent.kde.org/plasma/kscreen/-/merge_requests/269Don't allow screen overlap in display settings2024-03-25T17:28:57ZAkseli Lahtinenakselmo@akselmo.devDon't allow screen overlap in display settingsSometimes if screen allows picture-by-picture mode, toggling between the mode on and off
can set the displays overlap in the display settings.
This gives similar warning as with the screen gaps not being supported, but
when screens are ...Sometimes if screen allows picture-by-picture mode, toggling between the mode on and off
can set the displays overlap in the display settings.
This gives similar warning as with the screen gaps not being supported, but
when screens are overlapping.
BUG:4798496.1Akseli Lahtinenakselmo@akselmo.devAkseli Lahtinenakselmo@akselmo.devhttps://invent.kde.org/plasma/kscreen/-/merge_requests/267kcm: reorder adaptive sync options to be more logical2024-01-09T18:42:54ZXaver Huglkcm: reorder adaptive sync options to be more logical*very* minor thing but somehow annoys me*very* minor thing but somehow annoys me6https://invent.kde.org/plasma/kscreen/-/merge_requests/262plasmoid: adapt to changed inhibition request handling2024-01-23T20:08:48ZNatalie Clariusnatalie_clarius@yahoo.deplasmoid: adapt to changed inhibition request handlingThis was overlooked to adapt with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3294: The data engine now manages the cookie internally rather than passing it between the applet.
Also needs https://invent.kde.org/plasm...This was overlooked to adapt with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3294: The data engine now manages the cookie internally rather than passing it between the applet.
Also needs https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3611.
BUG: 4773556https://invent.kde.org/plasma/kscreen/-/merge_requests/257Add back a metadata key for api minimum version2023-11-20T12:00:14ZMarco MartinAdd back a metadata key for api minimum versionFixes an oversight: people are going to upgrade from 5 to 6, some will
have 3rd party plasmoids from the store that will still be for plasma5.
We want a different error message when we know the plasmoid is "old" In
Palsma4 times we used...Fixes an oversight: people are going to upgrade from 5 to 6, some will
have 3rd party plasmoids from the store that will still be for plasma5.
We want a different error message when we know the plasmoid is "old" In
Palsma4 times we used to have for the pure JavaScript plasmoids an api
version key that could be used for things like that.
This makes it a bit more future proof for any future api change there
will be
CCBUG:4744566https://invent.kde.org/plasma/kscreen/-/merge_requests/256kcm: Show the selected orientation again2023-11-19T16:43:59ZIsmael Asensiokcm: Show the selected orientation againThe buttons need to be explicitely set as `checkable` to show the `checked` state. (Might be a Qt6 thing)
| BEFORE | AFTER |
|--------|-------|
| ![kscreen-orientation-before.png](/uploads/b518d84970b6450d5bb5f9f8e44ec2b6/kscreen-orient...The buttons need to be explicitely set as `checkable` to show the `checked` state. (Might be a Qt6 thing)
| BEFORE | AFTER |
|--------|-------|
| ![kscreen-orientation-before.png](/uploads/b518d84970b6450d5bb5f9f8e44ec2b6/kscreen-orientation-before.png) | ![kscreen-orientation-after.png](/uploads/96a116678422cc5fb4c35d9f6fe5a8c5/kscreen-orientation-after.png) |6Ismael AsensioIsmael Asensiohttps://invent.kde.org/plasma/kscreen/-/merge_requests/254kcm: Fix QML warnings in OutputPanel2023-11-13T18:48:59ZIsmael Asensiokcm: Fix QML warnings in OutputPanelFixes two small typos that generate warnings on QML output
```
qrc:kcm/kcm_kscreen/OutputPanel.qml:217:9: Unable to assign \[undefined\] to double
qrc:kcm/kcm_kscreen/OutputPanel.qml:247: ReferenceError: label is not defined
```Fixes two small typos that generate warnings on QML output
```
qrc:kcm/kcm_kscreen/OutputPanel.qml:217:9: Unable to assign \[undefined\] to double
qrc:kcm/kcm_kscreen/OutputPanel.qml:247: ReferenceError: label is not defined
```6Ismael AsensioIsmael Asensiohttps://invent.kde.org/plasma/kscreen/-/merge_requests/252kcm: fix tearing label not being hidden on X112023-11-11T14:03:54ZXaver Huglkcm: fix tearing label not being hidden on X116https://invent.kde.org/plasma/kscreen/-/merge_requests/251OsdSelector: Fix setting currentIndex on a wrong hover transition2023-11-14T01:59:44Zivan tkachenkoOsdSelector: Fix setting currentIndex on a wrong hover transitionWhen a button gets un-hovered, it obviously should not draw any
attention to itself.
See also: https://invent.kde.org/plasma/powerdevil/-/merge_requests/273When a button gets un-hovered, it obviously should not draw any
attention to itself.
See also: https://invent.kde.org/plasma/powerdevil/-/merge_requests/2736ivan tkachenkoivan tkachenko