Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • KScreen
  • Merge requests
  • !35

feat(kcm): add revert timer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Chris Rizzitello requested to merge rizzitello/kscreen:revertTimer into master Aug 19, 2021
  • Overview 52
  • Commits 2
  • Pipelines 0
  • Changes 5

Updated Version of Feature Add Revert Timer with these additional Changes

  • Exposes A bug in system settings that after hitting apply a kcm loses activeFocus.
    • Can not force keyboard focus to the revert dialog
    • Action Shortcuts function correctly.
  • Rebased, Cleaned Commits.
  • New private method bool ConfigHelper::checkSaveandTestCommon(bool isSaveCheck)
    • used as a common back end for ConfigHelper::checkNeedsSave and ConfigHelper::shouldTestNewSettings
  • Use "Configuration" consistently
  • Cleaned up some Zixing Liu 's code
  • Use function OnFoo style Connection Type
  • Addressed the open threads
    • Do not prompt to keep configuration if the scale changed on X11.
    • Do not prompt when changing the way the config is stored
  • Use Kirigami OverlaySheet for a cleaner dialog
    • Use Enter and Escape as action shortcuts along with Alt+K / Alt+R
Edited Aug 26, 2021 by Chris Rizzitello
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: revertTimer