Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KScreen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • KScreen
  • Merge requests
  • !99

Fix Presentation Mode plasmoid for good

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged ivan tkachenko requested to merge work/ratijas/present-pc3 into master May 18, 2022
  • Overview 5
  • Commits 8
  • Pipelines 2
  • Changes 4

Port it away from context properties, to PlasmaComponents3; modernize JavaScript, document and pass down model properties explicitly, and remove one sizing hack involving an invisible CheckBox.

Overall, no visual changes except slightly larger margins somewhere (its a PRESENTATION MODE after all), autofixed checkbox layout issue (label sometimes drifts down) by porting away from PC2. Expected to have zero regressions.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/ratijas/present-pc3