1. 22 Mar, 2021 1 commit
  2. 18 Mar, 2021 1 commit
  3. 04 Mar, 2021 1 commit
  4. 08 Feb, 2021 1 commit
  5. 05 Feb, 2021 1 commit
    • David Edmundson's avatar
      Fix valgrind warning on startup · e3d45d25
      David Edmundson authored
      Before KSldApp's constructor we call QObject::QObject. This calls
      setParent which triggers a ParentChangedEvent on the virtual from the
      constructor (boo!)
      
      At this point our constructor hasn't run, so m_globalAccel isn't
      initiliased.
      
      Arguably this is a false positive as it always evaluates to the same
      thing, but we don't want to be reading uninitialised memory.
      e3d45d25
  6. 30 Jan, 2021 1 commit
  7. 29 Jan, 2021 1 commit
  8. 21 Jan, 2021 3 commits
  9. 16 Jan, 2021 1 commit
  10. 12 Jan, 2021 1 commit
  11. 09 Jan, 2021 1 commit
    • Lindsay Roberts's avatar
      Fix view geometry updates when screens added/removed · 6f2ef923
      Lindsay Roberts authored
      Screen geometry changed events could end up connected to the wrong
      views, or not at all. This could cause greeters not to be visible (and
      as such desktop contents visible), greeters at the wrong size or
      position and/or overlapped.
      
      We map Qt screens() by index to our own list of m_views, but Qt is free
      to reorder screens, and when screens are removed, what used to be e.g.
      index 0 could be removed, leading to connect() pointer to pointer
      mappings being incorrect. Since we also set geometry on add/remove this
      can lead to us changing to the correct geometry then back to geometry
      that is not covered by active screen, essentially making the greeter
      invisible, and no valid greeter visible.
      
      Since there is no uniqueness constraint for lambda connections, we can
      also end up with multiple screens updating different geometries on the
      same view, or repeated signals from the same screen.
      
      Fix this by only connecting screens once, and having the receiving
      lambda resolve the index to index mapping so connections are persistant
      with the life of the screen.
      
      BUG: 347934
      6f2ef923
  12. 17 Dec, 2020 1 commit
  13. 10 Dec, 2020 1 commit
  14. 20 Nov, 2020 1 commit
    • Marco Martin's avatar
      delay quit after successful password · a51dcaf7
      Marco Martin authored
      Make quit a queued connection to give the QML part time to eventually execute code connected to Authenticator::succeeded if any. All such connections would need to be immediate
      a51dcaf7
  15. 18 Nov, 2020 1 commit
  16. 09 Nov, 2020 1 commit
  17. 31 Oct, 2020 1 commit
  18. 24 Oct, 2020 1 commit
  19. 23 Oct, 2020 1 commit
  20. 06 Oct, 2020 1 commit
    • Marco Martin's avatar
      actually replace wallaper pages · 72439412
      Marco Martin authored
      it used to push a new page each time the wallpaer type was changed. this
      was kindof a "leak" as more and more pages were created and never
      deleted. use stack.replace instead.
      72439412
  21. 21 Sep, 2020 1 commit
  22. 19 Sep, 2020 1 commit
  23. 17 Sep, 2020 3 commits
  24. 16 Sep, 2020 1 commit
  25. 01 Sep, 2020 1 commit
  26. 20 Aug, 2020 1 commit
    • David Edmundson's avatar
      Update logind's SetLockedHint · 72b1e92e
      David Edmundson authored
      SetLockedHint exists so that an external system can determine if a
      session is locked or not without having to access the user's session
      bus.
      
      We support logind's requesting us to lock/unlock so it makes sense to
      support this also.
      
      CCBUG: 422591
      72b1e92e
  27. 29 Jul, 2020 1 commit
    • Fabian Vogt's avatar
      Drop seccomp sandboxing · f53b9b32
      Fabian Vogt authored
      Again and again the seccomp filter breaks the greeter, because of changes
      in Qt, Mesa or other drivers.
      
      On top of that, it doesn't even really provide security:
      - It defaults to allowing syscalls (early on, open was not allowed, but openat
        was, making it useless)
      - With the prop. nvidia driver or on wayland, creating and writing files is
        explicitly allowed
      - The DBus session bus is open, allowing arbitrary commands to be run
      
      This has a side effect: Without the sandbox, it's not necessary to have
      a long-running kcheckpass anymore, so the authenticator is now always using
      the "direct" mode.
      f53b9b32
  28. 26 Jul, 2020 1 commit
  29. 17 Jul, 2020 2 commits
  30. 13 Jul, 2020 3 commits
  31. 10 Jul, 2020 2 commits
  32. 08 Jul, 2020 1 commit
    • Luca Beltrame's avatar
      Fix race condition · 4905a365
      Luca Beltrame authored
      kcfg/kscreensaversettingsbase.kcfgc is used for two different targets:
      
      - kscreenlocker library
      - kscreenlocker_greet
      
      Only one of the two is actually asking to create the moc, so when
      building in parallel, the moc may need to be included, but would not be
      created yet, causing build failures.
      4905a365