GitLab

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT

GIT_SILENT

The whole concept is almost unused and there's no point in having it there but empty

See also https://phabricator.kde.org/T13553

SetLockedHint exists so that an external system can determine if a
session is locked or not without having to access the user's session
bus.

We support logind's requesting us to lock/unlock so it makes sense to
support this also.

CCBUG: 422591

Again and again the seccomp filter breaks the greeter, because of changes
in Qt, Mesa or other drivers.

On top of that, it doesn't even really provide security:
- It defaults to allowing syscalls (early on, open was not allowed, but openat
  was, making it useless)
- With the prop. nvidia driver or on wayland, creating and writing files is
  explicitly allowed
- The DBus session bus is open, allowing arbitrary commands to be run

This has a side effect: Without the sandbox, it's not necessary to have
a long-running kcheckpass anymore, so the authenticator is now always using
the "direct" mode.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Extract configuration related code into an internal library called settings
that the other targets are linked to.

The second race condition affects the kcm_screenlocker target.

This reverts commit f9522c46.

I've figured out how to get a new frameworks build for plasma \o/

(this still practically requires .73 api...)

this enables the picture of the day kded to monitor changes using
kconfigwatcher rather than a manual kdirwatch

Same as before: the KCM requires a moc which is not generated by itself,
and during parallel builds, it may not yet be done. Adding an explicit
dependency on the library (which is the one which generates the moc)
fixes the issue.

kcfg/kscreensaversettingsbase.kcfgc is used for two different targets:

- kscreenlocker library
- kscreenlocker_greet

Only one of the two is actually asking to create the moc, so when
building in parallel, the moc may need to be included, but would not be
created yet, causing build failures.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This is a straightforward port of the kcm to qml. Additonally the appearance tabs is now a page instead.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Otherwise it falls back to the name of the process and when the shortcut is
changed from the kcm inside systemsettings, the component would be displayed as
"System Settings" in the future. See also 9056449edc892e88788f189c0306c821c4b87e4d

GIT_SILENT

GIT_SILENT

Summary:
Adds category logging to the KScreenLocker daemon/library and the greeter.

Replaces all current uncategorized messages with categorized ones in these
parts.

Test Plan: Tested messages with autotests and QT_LOGGING_RULES="kscreenlocker*=true".

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28389

Summary:
The current KScreenLocker expects the Compositor to hand over the
KWayland::Server::Display pointer.

This has several disadvantages:
* In KScreenLocker functionality is duplicated which the compositor
  probably has setup already (creating client connections manually).
* The Display object has a way larger scope than what KScreenLocker
  actually needs.
* Ownership of the Display is unclear in regards to memory but also
  what the compositor is still allowed to do in comparision to KScreenLocker
  with the Display.
* KScreenLocker can only be integrated in compositors using KWayland for
  managing their wl_display protocol object.

Instead it is now enough to hand over a single file descriptor KScreenLocker
can use as its client endpoint to talk to the compositor.

Test Plan: Manually in Wayland session, autotest.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: apol

Differential Revision: https://phabricator.kde.org/D28082

Summary:
Give more info in debug output when and how the Greeter porcess exited and
what counter-measures are triggered to unregular exits.

Should simplify debugging.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: davidedmundson, zzag, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28081

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
When the "Lock Screen:" checkbox gets disabled the timeout spin box gets disabled too.
But the spin box is still enabled when the checkbox is disabled if the module is loaded.

Test Plan:
Disable screenlocking and restart module. The spin box should be disabled.
Before:
https://phabricator.kde.org/file/data/u6vxui546tvyluaoyo4l/PHID-FILE-b3uowaz5ar2xk7buwt6r/edit_before.png

After:
https://phabricator.kde.org/file/data/6cwds725zvhbtadcndxt/PHID-FILE-onnxln4uw4miuvcj7nbf/edit_after.png

Reviewers: mart, ervin

Reviewed By: ervin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27063

Summary:
This is useful for the phone specially. You can quickly turn on-off your
phone from lockscreen without actually unlocking it.

Test Plan: I need help testing it as my prefix session is broken currently.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27721

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary: It's a bit nicer than the factory thing

Test Plan: builds, kcm opens

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27581