KScreenLocker merge requestshttps://invent.kde.org/plasma/kscreenlocker/-/merge_requests2024-02-21T22:30:39Zhttps://invent.kde.org/plasma/kscreenlocker/-/merge_requests/206kcm: don't disable gracelock combobox when auto-lock is turned off2024-02-21T22:30:39ZNate Grahamkcm: don't disable gracelock combobox when auto-lock is turned offIt's still valid to want to configure this even when auto-lock is turned
off. For example you can manually lock the screen.
cc @merrittIt's still valid to want to configure this even when auto-lock is turned
off. For example you can manually lock the screen.
cc @merritt6.1https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/201Draft: greeter/greeterapp: handle event before sharing2024-02-04T18:37:56ZYifan ZhuDraft: greeter/greeterapp: handle event before sharingSomehow this fixes enter key not working in X11.
CCBUG: 478875
FIXED-IN: 6.0
The event sharing seems designed to synchronize input across multiple screens, but that appears to have been broken for quite a while...Somehow this fixes enter key not working in X11.
CCBUG: 478875
FIXED-IN: 6.0
The event sharing seems designed to synchronize input across multiple screens, but that appears to have been broken for quite a while...6Yifan ZhuYifan Zhuhttps://invent.kde.org/plasma/kscreenlocker/-/merge_requests/173greeter: build NoninteractiveAuthenticatorType and AuthenticatorsState as QML...2023-11-03T17:43:24ZFushan Wengreeter: build NoninteractiveAuthenticatorType and AuthenticatorsState as QML moduleThis helps fix testlockscreen in plasma-workspace.This helps fix testlockscreen in plasma-workspace.6https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/101WaylandLocker: Show/hide the background when requested2022-09-23T17:13:36ZArjen HiemstraWaylandLocker: Show/hide the background when requestedCurrently, the background is only shown if there's a problem with the
greeter. However, in certain cases we can end up with some desktop
contents shown when locking and going to sleep. To completely avoid
this, we can ensure the lock win...Currently, the background is only shown if there's a problem with the
greeter. However, in certain cases we can end up with some desktop
contents shown when locking and going to sleep. To completely avoid
this, we can ensure the lock window shows the background before we lock.
The greeter already fades from a black background to the actual screen,
so this doesn't seem to regress anything there. As a small side bonus,
it also improves the perceived responsiveness as when requesting a lock
or sleep, the black background shows up immediately while the system is
going to sleep.
CCBUG: 3167345.26Arjen HiemstraArjen Hiemstrahttps://invent.kde.org/plasma/kscreenlocker/-/merge_requests/96greeter: fix lock screen2022-09-19T21:00:24ZAndrei Kozlovgreeter: fix lock screenkscreenlocker_greet is crashed if call Interface::Lock() when m_daemon->lockState() == KSldApp::AcquiringLockkscreenlocker_greet is crashed if call Interface::Lock() when m_daemon->lockState() == KSldApp::AcquiringLock5.24https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/73kcm: fix 'Wallpaper type' combobox's width2022-05-27T17:35:55ZFushan Wenkcm: fix 'Wallpaper type' combobox's widthAdd `Layout.fillWidth: true` to extend the combobx.
BUG: 453592
FIXED-IN: 5.25
![图片](/uploads/e930435f853485a19162e3281b51b773/图片.png)Add `Layout.fillWidth: true` to extend the combobx.
BUG: 453592
FIXED-IN: 5.25
![图片](/uploads/e930435f853485a19162e3281b51b773/图片.png)5.25Fushan WenFushan Wenhttps://invent.kde.org/plasma/kscreenlocker/-/merge_requests/12Draft: Revisit a situation regarding the input methods in lockscreen2021-05-06T04:30:18ZBhushan ShahDraft: Revisit a situation regarding the input methods in lockscreen## Bit of history
Back in commit a355bca015be521fe677a324a1749d98adfc33d5, as a workaround(?) to the bug 306932 it was suggested by the @hein to allow simply set the QT_IM_MODULE to compose key. Which worked fine for X11, now after we s...## Bit of history
Back in commit a355bca015be521fe677a324a1749d98adfc33d5, as a workaround(?) to the bug 306932 it was suggested by the @hein to allow simply set the QT_IM_MODULE to compose key. Which worked fine for X11, now after we started using maliit keyboard for Plasma Mobile (old maliit and not new one), I changed that to allow the maliit as QT_IM_MODULE when using lockscreen greeter in the commit 44afdad7531947b7031d9b0f9f97595eeb90055f.
After that plasma/plasma-workspace@b6705f8d73bd0023e72ce2aafbe7526ae5fcfd2a, enabled using qtvirtualkeyboard for the lockscreen, condition was changed to explicitly set QT_IM_MODULE to qtvirtualkeyboard instead of compose previously in the commit c23f532224b7eb92a1d61e465f2990d77cf88313.
## Current situation
plasma/kwin@7aabd45df9c24ae6a84e2cdba8471c282ad656c2 added support for the `input-method-unstable-v1` in KWin wayland, which means that the we got support for the proper wayland input methods, and can use the [maliit2](https://maliit.github.io/news/2017/05/24/standalone-mode/) instead of old dbus method.
This requires that client does not have any `QT_IM_MODULE` set on it however, which means `QT_IM_MODULE=maliit` condition here is set to wrong, and that means it will try to set QT_IM_MODULE to maliit. Applying the patch I have here it makes it "work" with the recent kwin wayland and I can enter my password using the maliit, but this introduces several regressions and introduces the original bug we had back.
- Lockscreen Virtual Keyboard stops working on X11
- If input method is not configured (i.e `--input-method maliit-keyboard` is not passed to the kwin_wayland) then we end up with no virtual keyboard in the Lockscreen.
I am not sure what is correct solution here, but that said, current solution of setting QT_IM_MODULE to qtvirtualkeyboard by default is also "wrong" because that stops compose key from working and if your password have characters which requires compose key, well Good luck.
Ideally on wayland solution I have mind is to not set this environment variable at all if there is input-method registered with compositor (kwin_wayland). But currently the client (kscreenlocker_greet) have no way of knowing that from compositor using wayland APIs. But then X11 situation is also not so well here IMO.
I have opened this merge request as a point of discussion, please do not merge this as-is.5.21