1. 01 Sep, 2020 1 commit
  2. 28 Jul, 2020 1 commit
  3. 07 Jul, 2020 1 commit
  4. 29 Jun, 2020 2 commits
    • Fabian Vogt's avatar
      Migrate away from singe quote identifiers as well · 90d164f6
      Fabian Vogt authored
      Refactor the code a bit while at it.
      90d164f6
    • Fabian Vogt's avatar
      Bring back for saving usernames as well · b590b9df
      Fabian Vogt authored
      While this also reintroduces that a password field is used for entering, this
      is better than asking for the username every time, which is a regression
      compared to 5.18.
      
      Using a proper username input field would need changes in kwidgetsaddons or
      some refactoring to ask for username and password at once.
      
      Drop use of wallet->readEntry - it's custom binary data, so the content is
      entirely defined by whoever wrote it. We don't use writeEntry here, so using
      readEntry is invalid.
      b590b9df
  5. 23 Jun, 2020 1 commit
  6. 16 Jun, 2020 1 commit
  7. 03 Jun, 2020 1 commit
  8. 14 May, 2020 1 commit
  9. 06 May, 2020 1 commit
  10. 02 Apr, 2020 1 commit
  11. 02 Mar, 2020 3 commits
  12. 25 Feb, 2020 1 commit
  13. 18 Feb, 2020 1 commit
  14. 10 Feb, 2020 1 commit
  15. 06 Feb, 2020 1 commit
  16. 20 Jan, 2020 1 commit
    • Pali Rohár's avatar
      Extend parsing ssh prompt · e1914645
      Pali Rohár authored and Fabian Vogt's avatar Fabian Vogt committed
      Summary:
      * Add support for yes/no questions from ssh-agent and openssh client
      * Add support for more openssh client prompt lines
      * Better support for parsing git credential strings
      
      I wrote this patch 5 years ago and sent it to Armin Berres, current
      maintainer in that year. Seems it was never applied. Now I ported it for
      the last ksshaskpass version.
      
      Reviewers: fvogt
      
      Reviewed By: fvogt
      
      Subscribers: lbeltrame, ngraham, fvogt, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D9875
      e1914645
  17. 16 Jan, 2020 3 commits
  18. 07 Nov, 2019 1 commit
  19. 04 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · 99b444d9
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      99b444d9
  20. 10 Oct, 2019 2 commits
  21. 19 Sep, 2019 3 commits
  22. 21 Jul, 2019 1 commit
    • Martin Kostolný's avatar
      Suggestion - newline ending after password to output · 9d8614e0
      Martin Kostolný authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Summary:
      This is meant more as a question rather then actual code fix intention:
      
      I have a problem with `sudoedit` cmd line tool only accepting password from `ksshaskpass` if it is provided with newline in the end. Specifically in current state - calling:
      ```
      EDITOR=kate SUDO_ASKPASS=/usr/bin/ksshaskpass sudoedit -A /etc/hosts
      ```
      ...will result in a Ksshaskpass dialog and after entering the password the command just ends. But after applying this patch it starts working and kate is opened.
      
      I tried other graphical askpass programs, namely ssh-askpass, qt4-ssh-askpass, lxqt-ssh-askpass and gnome-ssh-askpass2 (gtk2). They all work nicely with sudoedit.
      
      My question is: Is it intentional that the password is not returned with newline? Should I ask sudoedit guys instead? Or is the problem elswhere, e.g. in KPasswordDialog (KF5 kwidgetaddons)? Thanks!
      
      PS: Please add reviewers as needed, I don't know the proper flow here, sorry :).
      
      Test Plan: Tested on sudoedit as well as git connecting to github with username and password.
      
      Reviewers: cfeck, davidedmundson
      
      Reviewed By: davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D4775
      9d8614e0
  23. 16 May, 2019 3 commits
  24. 09 May, 2019 1 commit
  25. 17 Jan, 2019 3 commits
  26. 04 Oct, 2018 2 commits
  27. 19 Sep, 2018 1 commit