1. 31 Mar, 2020 1 commit
  2. 10 Mar, 2020 1 commit
  3. 05 Mar, 2020 1 commit
    • Jakob Kummerow's avatar
      Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs · 031bd760
      Jakob Kummerow authored
      Summary:
      Getting CPU information starts with reading /proc/cpuinfo into a buffer; if that buffer is too small, then no information will be returned at all (updateCpuInfo() will return -1, so initCpuInfo() will return early); the consequence is that ksysguardd/ksysguard/plasmaengineexplorer won't know about "system/cores" or "cpu/system/AverageClock"; that in turn will make the "System Load Viewer" plasmoid completely dysfunctional (it won't show *any* data) because it relies on "system/cores" being available.
      
      The buffer is currently 32KiB large, which is not enough on modern hardware (e.g. 12-core/24-thread systems exceed it). This patch lowers the initial size to 8KiB to be as memory-efficient as possible on low-end systems (dual/quadcore systems shouldn't ever need to grow it), and grows the buffer size as needed to accommodate arbitrarily many CPUs (tested on a 72-thread system, where the buffer grows four times, reaching 128KiB final size).
      
      When the buffer needs to grow, its size is doubled, so the overall cost of the growth scales linearly with the file size (on average, each byte is copied to a larger buffer at most once). Also, the buffer size is remembered as long as the process runs, so the cost of the growth is only incurred once on startup (or if additional CPUs come online, which is probably rare).
      
      I've verified locally that this patch fixes the issue: the System Log Viewer plasmoid shows data as expected afterwards.
      
      BUG: 384515
      
      Reviewers: davidedmundson, ahiemstra
      
      Reviewed By: ahiemstra
      
      Subscribers: ngraham, ahiemstra, cfeck, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27362
      031bd760
  4. 02 Mar, 2020 1 commit
  5. 27 Feb, 2020 1 commit
  6. 25 Feb, 2020 1 commit
  7. 24 Feb, 2020 1 commit
    • David Edmundson's avatar
      Unify ksysguard cpu clock speed names · 4e656a45
      David Edmundson authored
      Summary:
      For every other sensor the human readable name of cpu0 is "CPU 1" and so
      on, except clock speed
      
      Before (in ksysguardd -i)
      ksysguardd> cpu/cpu0/sys?
      CPU 1 System Load       0       100     %
      
      ksysguardd> cpu/cpu0/clock?
      CPU0 Clock Frequency    0       0       MHz
      
      With this patch they're uniform
      
      Doesn't make a big difference as SensorManager goes through a big
      translation and disregards this anyway.
      
      Test Plan: #plasma
      
      Reviewers: ahiemstra
      
      Reviewed By: ahiemstra
      
      Subscribers: ahiemstra, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D26857
      4e656a45
  8. 18 Feb, 2020 1 commit
  9. 06 Feb, 2020 1 commit
  10. 28 Jan, 2020 1 commit
  11. 20 Jan, 2020 1 commit
  12. 16 Jan, 2020 1 commit
  13. 14 Jan, 2020 1 commit
  14. 12 Jan, 2020 1 commit
  15. 07 Jan, 2020 2 commits
  16. 04 Jan, 2020 1 commit
  17. 30 Dec, 2019 3 commits
  18. 25 Dec, 2019 1 commit
  19. 19 Dec, 2019 1 commit
  20. 13 Dec, 2019 1 commit
  21. 07 Dec, 2019 1 commit
  22. 03 Dec, 2019 1 commit
  23. 29 Nov, 2019 3 commits
  24. 27 Nov, 2019 1 commit
    • Arjen Hiemstra's avatar
      Add Total/Available/Allocated memory sensors · 05e26b28
      Arjen Hiemstra authored
      Summary:
      This exposes the previously hidden Total memory amount as
      "mem/physical/total".
      
      It also add an "Available" sensor, which reads the "MemAvailable" field
      from /proc/meminfo. "Available" provides an estimate with how much
      memory is available for starting new applications.
      
      Finally, it adds an "Allocated" sensor, which equal "Total - Available"
      and represents the total amount allocated to all currently running
      applications.
      
      Test Plan: The sensor browser now lists "total", "available" and "allocated" sensors.
      
      Reviewers: #plasma, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D25305
      05e26b28
  25. 26 Nov, 2019 1 commit
  26. 23 Nov, 2019 1 commit
  27. 14 Nov, 2019 2 commits
  28. 12 Nov, 2019 1 commit
  29. 09 Nov, 2019 2 commits
  30. 06 Nov, 2019 2 commits
  31. 04 Nov, 2019 1 commit
    • David Edmundson's avatar
      Add KDEClangFormat cmake support · 75c0b315
      David Edmundson authored
      Summary:
      This allows devs to run: "make clang-format" and format all files easily
      using the preset KDE clang format style
      
      This patch adds support so devs can easily test the intended formatting
      now, it doesn't change the code yet.
      
      Doing an initial run to commit everything will happen later.
      
      Test Plan:
      Ran script
      git diff was full of amazingly cleaned code
      
      See D25134
      75c0b315
  32. 03 Nov, 2019 1 commit