GitLab

GIT_SILENT

GIT_SILENT

Jakob Kummerow authored Feb 19, 2020 and Arjen Hiemstra committed Mar 05, 2020

Summary:
Getting CPU information starts with reading /proc/cpuinfo into a buffer; if that buffer is too small, then no information will be returned at all (updateCpuInfo() will return -1, so initCpuInfo() will return early); the consequence is that ksysguardd/ksysguard/plasmaengineexplorer won't know about "system/cores" or "cpu/system/AverageClock"; that in turn will make the "System Load Viewer" plasmoid completely dysfunctional (it won't show *any* data) because it relies on "system/cores" being available.

The buffer is currently 32KiB large, which is not enough on modern hardware (e.g. 12-core/24-thread systems exceed it). This patch lowers the initial size to 8KiB to be as memory-efficient as possible on low-end systems (dual/quadcore systems shouldn't ever need to grow it), and grows the buffer size as needed to accommodate arbitrarily many CPUs (tested on a 72-thread system, where the buffer grows four times, reaching 128KiB final size).

When the buffer needs to grow, its size is doubled, so the overall cost of the growth scales linearly with the file size (on average, each byte is copied to a larger buffer at most once). Also, the buffer size is remembered as long as the process runs, so the cost of the growth is only incurred once on startup (or if additional CPUs come online, which is probably rare).

I've verified locally that this patch fixes the issue: the System Log Viewer plasmoid shows data as expected afterwards.

BUG: 384515

Reviewers: davidedmundson, ahiemstra

Reviewed By: ahiemstra

Subscribers: ngraham, ahiemstra, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27362

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

Summary:
For every other sensor the human readable name of cpu0 is "CPU 1" and so
on, except clock speed

Before (in ksysguardd -i)
ksysguardd> cpu/cpu0/sys?
CPU 1 System Load       0       100     %

ksysguardd> cpu/cpu0/clock?
CPU0 Clock Frequency    0       0       MHz

With this patch they're uniform

Doesn't make a big difference as SensorManager goes through a big
translation and disregards this anyway.

Test Plan: #plasma

Reviewers: ahiemstra

Reviewed By: ahiemstra

Subscribers: ahiemstra, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26857

GIT_SILENT

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

José Jorge authored Nov 29, 2019 and Arjen Hiemstra committed Nov 29, 2019

Summary:
Since kernel 2.6.24 in 2008, the /proc/acpi/battery interface is deprecated.
There is for years no updated kernel which wouldn't provide the /sys/class/power_supply/BAT0 in a laptop
This patch removes the useless old path, and uses the sysfs to provide 3 informations :
- current flow in mA (charge or discharge)
- charge percent against last completed full charge
- charge percent against battery by design charge

Ref:
https://cateee.net/lkddb/web-lkddb/ACPI_PROCFS_POWER.html
https://bbs.archlinux.org/viewtopic.php?id=97761

Reviewers: davidedmundson, #plasma, ahiemstra

Reviewed By: ahiemstra

Subscribers: alexde, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25018

This reverts commit 9022a937.

Script Kiddy authored Nov 29, 2019 and Arjen Hiemstra committed Nov 29, 2019

Summary:
Since kernel 2.6.24 in 2008, the /proc/acpi/battery interface is deprecated.
There is for years no updated kernel which wouldn't provide the /sys/class/power_supply/BAT0 in a laptop
This patch removes the useless old path, and uses the sysfs to provide 3 informations :
- current flow in mA (charge or discharge)
- charge percent against last completed full charge
- charge percent against battery by design charge

Ref:
https://cateee.net/lkddb/web-lkddb/ACPI_PROCFS_POWER.html
https://bbs.archlinux.org/viewtopic.php?id=97761

Reviewers: davidedmundson, #plasma, ahiemstra

Reviewed By: ahiemstra

Subscribers: alexde, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25018

Summary:
This exposes the previously hidden Total memory amount as
"mem/physical/total".

It also add an "Available" sensor, which reads the "MemAvailable" field
from /proc/meminfo. "Available" provides an estimate with how much
memory is available for starting new applications.

Finally, it adds an "Allocated" sensor, which equal "Total - Available"
and represents the total amount allocated to all currently running
applications.

Test Plan: The sensor browser now lists "total", "available" and "allocated" sensors.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25305

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This makes it show up as an app in the Notifications KCM

CCBUG: 407701

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
This allows devs to run: "make clang-format" and format all files easily
using the preset KDE clang format style

This patch adds support so devs can easily test the intended formatting
now, it doesn't change the code yet.

Doing an initial run to commit everything will happen later.

Test Plan:
Ran script
git diff was full of amazingly cleaned code

See D25134