1. 29 Jul, 2020 16 commits
  2. 28 Jul, 2020 1 commit
  3. 26 Jul, 2020 1 commit
  4. 24 Jul, 2020 1 commit
  5. 15 Jul, 2020 1 commit
  6. 13 Jul, 2020 1 commit
  7. 10 Jul, 2020 1 commit
  8. 08 Jul, 2020 1 commit
  9. 07 Jul, 2020 1 commit
  10. 02 Jul, 2020 2 commits
  11. 01 Jul, 2020 11 commits
    • Adriaan de Groot's avatar
      Only apply the (changed) settings if the dialog is · 3cd58736
      Adriaan de Groot authored
      finished via the OK button (or some other way of accepting
      the dialog). Clicking *cancel* should not apply the
      changed settings.
      
      BUG: 423260
      3cd58736
    • Adriaan de Groot's avatar
      Fix typo in comment (modally) · c896cb8b
      Adriaan de Groot authored
      c896cb8b
    • Adriaan de Groot's avatar
      Fix buffer-overflow · 566d5fab
      Adriaan de Groot authored
      The buffer for a sscanf() %s argument with a length needs to be
      1 longer than the length, for the terminating NUL.
      
      BUG: 346228
      566d5fab
    • Adriaan de Groot's avatar
      Refactor precision- and percentage-handling · 9d3f3cde
      Adriaan de Groot authored
      The precision -1 was used in places where it meant "use the default
      precision". For KLocale, this went through decimalPlaces() and
      usually returned 2. For QLocale, this is invalid, and 6 is normally used.
      
      This meant that 1% was displayed as 1.000000%, which is kind of useless,
      just like 24KiB/s was displayed as 24.000000KiB/s -- implying a
      network which could conceivably also transmit 1 bit in a little over
      2 minutes, and measure that accurately.
      
      Provide convenience methods (static, inline) for providing more
      sensible precisions.
      9d3f3cde
    • Adriaan de Groot's avatar
      Beam values also need a format · f1ce8330
      Adriaan de Groot authored
      f1ce8330
    • Adriaan de Groot's avatar
      Fix tooltip display of double (float) values. · 6d3527a3
      Adriaan de Groot authored
      The port from KLocale -> QLocale left out the format-specifier
      in the call to QLocale::toString(double, char, int), so we
      ended up with the "precision" specifier as the char parameter --
      speficying the format char. It looks like 0 (NUL) is interpreted
      as 'f' on the Qt side, and precision is then 6.
      
      The result was tooltip output like "31,405,564.000000 KiB"
      which is nonsense -- there is no reason for six digits
      of precision when displaying KiB until such a time as
      micro-kibibytes ( 1/122 of a bit) are addressable.
      
      Force format 'f' to avoid scientific notation, and
      set precision to 0 for integer sensors, -1 (I assume that becomes
      6 again internally in QLocale::toString()) otherwise.
      The static_assert() is there as a reminder of which method
      in QLocale should be called here.
      6d3527a3
    • Adriaan de Groot's avatar
      Refactor the selection of circle-character · b3ece5c0
      Adriaan de Groot authored
      Using 0x25CF or '#' is a bit of magic constant conjuration,
      so factor it into a named constant and a convenience function.
      b3ece5c0
    • Arjen Hiemstra's avatar
      osinfo: Also check if pretty hostname is empty · c7dbcff5
      Arjen Hiemstra authored
      Right now the code just checks if the pretty hostname exists, not if it
      is empty. This fixes that.
      c7dbcff5
    • Adriaan de Groot's avatar
      Re-calibrate sensor if the range is set to auto-calibrate · 04200fac
      Adriaan de Groot authored
      When the range is set to 0-0 from the properties dialog,
      re-calibrate the sensor like it would be when being
      re-loaded from the settings file. Otherwise, the range
      is set and kept and the sensor cannot display anything
      until ksysguard is re-started (and it gets re-calibrated
      on load).
      04200fac
    • Adriaan de Groot's avatar
      Avoid (double) divide-by-zero. · b972e777
      Adriaan de Groot authored
      On startup, maxValue may be 0 (e.g. for auto-adjusting sensors)
      and then we get a divide-by-zero. In practice this hammers the
      resulting integer to negative-biggity, but it's still undefined behavior.
      
      Just use 0 instead.
      
      While here, massage the C-style cast as well. Make the whole
      ternary expression a double, then cast.
      b972e777
    • Adriaan de Groot's avatar
      Remove unused · 14a7a4bc
      Adriaan de Groot authored
      14a7a4bc
  12. 30 Jun, 2020 3 commits