1. 03 Aug, 2020 1 commit
  2. 31 Jul, 2020 2 commits
  3. 30 Jul, 2020 2 commits
  4. 29 Jul, 2020 18 commits
  5. 28 Jul, 2020 1 commit
  6. 26 Jul, 2020 1 commit
  7. 24 Jul, 2020 1 commit
  8. 15 Jul, 2020 1 commit
  9. 13 Jul, 2020 1 commit
  10. 10 Jul, 2020 1 commit
  11. 08 Jul, 2020 1 commit
  12. 07 Jul, 2020 1 commit
  13. 02 Jul, 2020 2 commits
  14. 01 Jul, 2020 7 commits
    • Adriaan de Groot's avatar
      Only apply the (changed) settings if the dialog is · 3cd58736
      Adriaan de Groot authored
      finished via the OK button (or some other way of accepting
      the dialog). Clicking *cancel* should not apply the
      changed settings.
      BUG: 423260
    • Adriaan de Groot's avatar
      Fix typo in comment (modally) · c896cb8b
      Adriaan de Groot authored
    • Adriaan de Groot's avatar
      Fix buffer-overflow · 566d5fab
      Adriaan de Groot authored
      The buffer for a sscanf() %s argument with a length needs to be
      1 longer than the length, for the terminating NUL.
      BUG: 346228
    • Adriaan de Groot's avatar
      Refactor precision- and percentage-handling · 9d3f3cde
      Adriaan de Groot authored
      The precision -1 was used in places where it meant "use the default
      precision". For KLocale, this went through decimalPlaces() and
      usually returned 2. For QLocale, this is invalid, and 6 is normally used.
      This meant that 1% was displayed as 1.000000%, which is kind of useless,
      just like 24KiB/s was displayed as 24.000000KiB/s -- implying a
      network which could conceivably also transmit 1 bit in a little over
      2 minutes, and measure that accurately.
      Provide convenience methods (static, inline) for providing more
      sensible precisions.
    • Adriaan de Groot's avatar
      Beam values also need a format · f1ce8330
      Adriaan de Groot authored
    • Adriaan de Groot's avatar
      Fix tooltip display of double (float) values. · 6d3527a3
      Adriaan de Groot authored
      The port from KLocale -> QLocale left out the format-specifier
      in the call to QLocale::toString(double, char, int), so we
      ended up with the "precision" specifier as the char parameter --
      speficying the format char. It looks like 0 (NUL) is interpreted
      as 'f' on the Qt side, and precision is then 6.
      The result was tooltip output like "31,405,564.000000 KiB"
      which is nonsense -- there is no reason for six digits
      of precision when displaying KiB until such a time as
      micro-kibibytes ( 1/122 of a bit) are addressable.
      Force format 'f' to avoid scientific notation, and
      set precision to 0 for integer sensors, -1 (I assume that becomes
      6 again internally in QLocale::toString()) otherwise.
      The static_assert() is there as a reminder of which method
      in QLocale should be called here.
    • Adriaan de Groot's avatar
      Refactor the selection of circle-character · b3ece5c0
      Adriaan de Groot authored
      Using 0x25CF or '#' is a bit of magic constant conjuration,
      so factor it into a named constant and a convenience function.