GitLab

Follow-up to e3d7e76b.

The value should be just that, the value, otherwise we fail to parse it
on the other side.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 421532

The "Used" label is defined a few lines above (thanks Paolo Zamponi
for spotting this).

While this is a message break, it is at the same time an important
bugfix.

These types cannot be handled by the kstats daemon so we should not even
try to list them.

GIT_SILENT

Instead of adding new strings, making it possible to do this in 5.19

It's still not very nice but at least this allows us to provide proper
display names.

This allows the client to show a proper display name for these instead
of just an id.

This prevents duplicate plugins (like one local and one system) from
being loaded, making it less likely that the one wrong is loaded.

CCMAIL: kde@davidedmundson.co.uk
CCMAIL: ahiemstra@heimr.nl

CCMAIL: kde@davidedmundson.co.uk
CCMAIL: ahiemstra@heimr.nl

Summary: BUG: 421514

Reviewers: apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29753

Summary:
labels for CPU frequency are "CPU 1 Clock Frequency". Network speeds
have the interface name at front.  Partitions didn't match, leaving the
key in the graph to be just "Available" several times if you plotted
multiple disks.

This adds a prefix so it's consistent.

BUG: 421513

Reviewers: lbeltrame, #plasma, ahiemstra

Reviewed By: ahiemstra

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29752

GIT_SILENT

Reviewers: ahiemstra

Reviewed By: ahiemstra

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29717

Summary:
Since there is little reason to monitor loop devices, exclude them
altogether from the partition and disk sensors.

This fixes cases where there are a significant amount of snaps,
which are all mounted as loop devices and thus cause partition and
disk sensors to appear, which potentially causes major slowdowns.

Test Plan: Snaps are excluded from the list of sensors in KSysGuard.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29688

Summary:
Many of the shorter strings are not really informative, so add context
so translators can figure out what they mean. Some of the strings were
also wrong, those have been corrected as well.

Test Plan: Still compiles.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29721

Summary:
With D29302 all KSysGuard targets have been placed in the KSysGuard namespace
and the KF5 versions deprecated. This changes KSysGuard to use the new
namespace. In addition, it renames the libkstats target from "PW5::KSysGuardBackend"
to "KSysGuard::StatsBackend".

Test Plan: Things still compile.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29507

Summary:
ksysguardd, whilst good, has a few problems

The code is a bit archaic, it relies on a polling API, which is overhead
for infrequently changed values or where setting up a monitor has a big
overhead.

It also moves the problem of translations into the daemon, allowing for
better extensibility without requiring client side changes.

The daemon is based around a typical OO model. Plugins have lists of
objects, those objects have properties using common Qt patterns. A
property also has various metadata.

For full compatibility ksgrd is wrapped and the plan is to land with the
bridge, then slowly land patches that use the new API natively.

An nvidia plugin is also added to show the API being used in another
format.

This is all consumed by the new API posted in D28141

Test Plan:
Unit test
Used with the new library to create a new suite of applet (upcoming patch)
Used in a ported ksysguard

Reviewers: #plasma, mart, ngraham, ahiemstra

Reviewed By: #plasma, mart...

GIT_SILENT

Summary:
Depending on hardware, Linux kernel exports battery state in
different files. Previously only charge_now, charge_full and current_now
were available in ksysguard. With this commit all are selectable.

While we have now screens with more than 1000 pixels height,
a percentage with 100 steps will show a ladder. This commit also
make the created graphs nicer by giving 1000 steps.

Reviewers: #plasma, davidedmundson, ahiemstra

Reviewed By: ahiemstra

Subscribers: anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28127

Summary:
This adds a "total" sensor for each partition that reports the total
space for that partition. It also adds a new "all" category with sensors
that report the used/free space for all partitions.

Test Plan: New sesnors are available in KSysGuard

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28438

GIT_SILENT

Summary:
Some AMD GPUs do report power which can be read by lm-sensors. This diff adds support for showing those power readings in ksysguard.

Note: SENSORS_SUBFEATURE_POWER_AVERAGE is checked as a backup, because AMDGPU reports power as an average and not as input.

Reviewers: mlaurent, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28166

GIT_SILENT

Summary:
Getting CPU information starts with reading /proc/cpuinfo into a buffer; if that buffer is too small, then no information will be returned at all (updateCpuInfo() will return -1, so initCpuInfo() will return early); the consequence is that ksysguardd/ksysguard/plasmaengineexplorer won't know about "system/cores" or "cpu/system/AverageClock"; that in turn will make the "System Load Viewer" plasmoid completely dysfunctional (it won't show *any* data) because it relies on "system/cores" being available.

The buffer is currently 32KiB large, which is not enough on modern hardware (e.g. 12-core/24-thread systems exceed it). This patch lowers the initial size to 8KiB to be as memory-efficient as possible on low-end systems (dual/quadcore systems shouldn't ever need to grow it), and grows the buffer size as needed to accommodate arbitrarily many CPUs (tested on a 72-thread system, where the buffer grows four times, reaching 128KiB final size).

When the buffer needs to grow, its size is doubled, so the overall cost of the growth scales linearly with the file size (on average, each byte is copied to a larger buffer at most once). Also, the buffer size is remembered as long as the process runs, so the cost of the growth is only incurred once on startup (or if additional CPUs come online, which is probably rare).

I've verified locally that this patch fixes the issue: the System Log Viewer plasmoid shows data as expected afterwards.

BUG: 384515

Reviewers: davidedmundson, ahiemstra

Reviewed By: ahiemstra

Subscribers: ngraham, ahiemstra, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27362

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"